This repository was archived by the owner on Nov 8, 2024. It is now read-only.
add try except to all public client methods (FF-947) #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorgiomartini0
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Code changes look good to me. I noticed that all the get_<type>_assignment methods are identical other than the last argument to get_assignment_variation, so maybe this could be refactored to reduce code duplication (especially if error handling becomes more complex in the future). Not needed for this PR.
sameerank
approved these changes
Oct 12, 2023
| api_key: str | ||
| base_url: str = "https://fscdn.eppo.cloud/api" | ||
| assignment_logger: AssignmentLogger | ||
| is_graceful_mode: bool = True |
There was a problem hiding this comment.
Just wondering, is this intended for customers to set? I.e. will this need an update in the docs?
There was a problem hiding this comment.
Yes they can set this, for example in dev mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
Add protection for exceptions in our SDKs from bubbling out to our customers' applications by wrapping all public methods in a try/catch.
Description
is_graceful_modeis on by default - this is prevent exceptions, expect forValueErrorfrom bubbling up as this is the way python performs validation. we throw this exception if theflagKeyis not set invalidate_not_blankHow has this been tested?