This repository was archived by the owner on Nov 8, 2024. It is now read-only.
add support for targeting rule evaluation with semver #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpai
force-pushed
the
varun/semver
branch
4 times, most recently
from
e75e242 to
8990bae
Compare
leoromanovsky
approved these changes
Feb 14, 2024
aarsilv
approved these changes
Feb 16, 2024
| return False | ||
|
|
||
|
|
||
| def is_valid_semver(value: str): |
| return isinstance( | ||
| subject_value, numbers.Number | ||
| ) and evaluate_numeric_condition(subject_value, condition) | ||
| # Numeric operator: value could be numeric or semver. |
There was a problem hiding this comment.
I appreciate the comments 🙌
| assert find_matching_rule({"age": 99}, [rule]) == rule | ||
|
|
||
|
|
||
| def test_find_matching_rule_with_semver(): |
Comment on lines
+73
to
+75
| assert find_matching_rule({"version": "1.1.0"}, [semver_rule]) is semver_rule | ||
| assert find_matching_rule({"version": "2.0.0"}, [semver_rule]) is semver_rule | ||
| assert find_matching_rule({"version": "2.1.0"}, [semver_rule]) is None |
There was a problem hiding this comment.
just for shits, to make sure more than just a string comparison is at play, consider having test data so that we do something like making sure "1.12.3" is greater than "1.2.0"
This was referenced Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Eppo's RAC API will start returning targeting rule values containing semver strings. Our SDKs need to be able to parse these strings and perform rule evaluation on them. Some examples of other SDKs:
Eppo-exp/js-sdk-common#38
Eppo-exp/eppo-ios-sdk#10
Description
The operations
lt,gt,lte,gteapply to both numeric values and semver strings. Previously it was only numeric values.Behavior of un-upgraded SDKs
They will continue to assume that only numeric values will be present for the
lt,gt,lte,gteoperations.