Update docker images to Ubuntu 22.04 #644
Conversation
add prebuilt packages to repo, fix related issues with CMake
mcserep
added
Kind: Refactor 🔃
Target: Developer environment
revert renaming of libgit2 and recombine apt installs, remove ugly LLVM version setting, add LLVM_DIR to env variables instead
docker/dev/install_odb.sh
Outdated
| esac | ||
| bpkg install --all --recursive | ||
| # Copy to /usr | ||
| cp -rn /odb_install/* /usr |
There was a problem hiding this comment.
Conventionally the /usr folder is for files installed through the package manager. Locally compiled programs should go to /usr/local.
Therefore, simply /usr/local should be given as the install path and no copying is needed.
There was a problem hiding this comment.
We have discussed on the weekly meeting, that this could also be a valid approach. However, I have further doubts, as the install folder could also contain symlinks. If those are not relative, but absolute, copying them would result in invalid links. Therefore installing directly into /usr/local/ would still be preferred.
|
The DEB files should be removed from the PR. Apart from that, and the issues mentioned above, it looks good and ready to merge 🚀 |
All 3 docker images were updated to Ubuntu 22.04. Thrift and ODB were manually built inside the dev container and then packaged because their official Ubuntu repository versions don't work with the codebase. (Thrift can be installed from the repo once it's updated to 0.16 #630)
Looking for feedback and suggestions on how to handle the relatively big pre-built packages. Also more extensive testing.
Closes #632