Rework PythonPathContext #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=========================================
Coverage ? 88.27%
=========================================
Files ? 19
Lines ? 2303
Branches ? 498
=========================================
Hits ? 2033
Misses ? 186
Partials ? 84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #52
Default the path insert location to index 0, and be more permissive with removing the path when the import mangles the path. While this solves some issues, it also introduces new failure modes that don't currently exists. However, being robust to these failure modes would require a significant amount of computation and the new edge cases should be much rarer than the current set of edge cases (which have happened in practice).