Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework PythonPathContext #53

Merged
merged 3 commits into from
Oct 27, 2019
Merged

Rework PythonPathContext #53

merged 3 commits into from
Oct 27, 2019

Conversation

Erotemic
Copy link
Owner

Addresses issue #52

Default the path insert location to index 0, and be more permissive with removing the path when the import mangles the path. While this solves some issues, it also introduces new failure modes that don't currently exists. However, being robust to these failure modes would require a significant amount of computation and the new edge cases should be much rarer than the current set of edge cases (which have happened in practice).

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8c4e0ad). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage          ?   88.27%           
=========================================
  Files             ?       19           
  Lines             ?     2303           
  Branches          ?      498           
=========================================
  Hits              ?     2033           
  Misses            ?      186           
  Partials          ?       84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants