Add workflow to publish crate #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
force-pushed
the
feat/publish-crate
branch
from
f81527f to
ef95586
Compare
Move build, lint, test, docs, and publish jobs into the same action. Require successful completion of build, test, lint, and docs before publishing a new version of the crate.
jbearer
force-pushed
the
feat/publish-crate
branch
from
7b17da1 to
836f537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I think this does:
Cargo.toml(forces us to keepCargo.tomlup to date)mainthat changes the versionI think a consequence of this is that every merge to
mainwill trigger a new release. For a tiny utility crate like this, that's probably ok. But it might be better to have a separatereleasebranch, trigger this action byreleaseinstead ofmain, and then mergingmainintoreleaseis a manual action that triggers new versions being published. In that case we would probably want some kind of branch protection rule where the only changes allowed toreleaseare fast-forwards frommain.@Ancient123 WDYT about this approach?