-
Notifications
You must be signed in to change notification settings - Fork 8
Merge feature branch Offline map areas to v.next #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changes to initialize preplanned map area * update apiDump file * add newline and copyright header * remove initializer for modifier * address code review comments * remove spacer
* Changes to enhance the preplanned map areas list * Add preplanned areas state, offlineMapInfo * add newline add strings.xml to t9nmanifest.txt * update api file remove composableSingletons * address code review comments
* Add backing properties * remove commented code * remove unused imports
* WIP * pair programming progress * clean up app code * Make parent directory if absent * more pair programming progress * Monday refactor work, updated workmanager to observe UUID, updated OfflineMapState to initialize with Context, changed microapp to use ViewModel * add newline and TODO * add portalItemId of the webmap's portalItem to the file download path --------- Co-authored-by: Shubham Sharma <shubhamsharma@esri.com>
…odel scope (#856) * Add fix so that we always run the workManagerRepository fun in the viewModel scope so the long running collect operations survive orientation changes * update api file remove unused code * address code review comments * update api file * removed unused import
* Add fix so that we always run the workManagerRepository fun in the viewModel scope so the long running collect operations survive orientation changes * update api file remove unused code * WIP * WIP * some clean up and added currently open message * remove unused fun update api file * update api file * remove unused import * address code review comments * revert notification changes * move WorkManagerRepository to workmanager package
* Add fix so that we always run the workManagerRepository fun in the viewModel scope so the long running collect operations survive orientation changes * update api file remove unused code * WIP * WIP * some clean up and added currently open message * remove unused fun update api file * update api file * remove unused import * Add changes to toggle between online and offline map * remove unused code * refactor onSelectionChangedListerner name in PreplannedMapAreaState
* WIP * WIP * Changes to show map area details in a modal bottomsheet * copy info file only if it exists in the pending directory * add scroll to bottomsheet add logic to delete offlinemapinfo along with the last map area to be deleted * refactor MapAreaDetailsScreen * add newline * update build.gradle to omit composableSingleton for MapAreaDetailsScreen * cancel scope after initialization * Add remove download methods to OfflineRepository rename delete download button Text * update offlineMapInfos * address code review comments * address code review comments * apply feedback
#883) * Changes to make OfflineRepository Singleton, to support single instance of OfflineMapInfos to work as a SnapShotStateList * some clean up * update api file
Add Modifications to copyright
* refactor common code * WIP * add newline * update build.gradle * address code review comments
* update check to determine if the device is offline * update logic * address code review feedback * update micro app upate offlineMapState
puneet-pdx
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubham7109 LGTM 👍🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #6138
Description:
PR to merge feature branch Offline map areas to v.next.
Pre-merge Checklist
https://runtime-kotlin.esri.com/view/all/job/vtest/job/toolkit/837/