Remove offset on certain potion strength values

[uf0h]

fixes #3589

[pop4959]

Are you sure that check wasn't important for something else in the code?

[uf0h]

Have checked usage with power at crazier levels (+50) and it works as expected.

I'm of the opinion if any user opts to set potion power a to crazier amount it's their responsibility but let me know what you think about setting an upper limit; just this time higher than 4.

[pop4959]

Have you checked all the way back to Minecraft 1.8? Sometimes weird things like this result from incompatibilities in older versions. Although it could very well be that this check isn't needed anymore, just needs to be absolutely 100% confirmed so that we aren't reintroducing a bug or something.

[uf0h]

Shows working effects: link
Shows lore of potions: link

[pop4959]

Ah I see, maybe it would be smart to still add a potions.unsafe permission node + config similar to the enchantments stuff, for the levels that do not display properly in game.

[VoltroXP]

Looks good to me 👍

[mdcfe]

ce51a07 added this offset behaviour so that power:<value> meta tags would match the names that vanilla uses for each amplifier value - potion amplifier values are 1 less than the value displayed in the name, so Strength I actually has an amplifier value of 0, Strength III has a value of 2 etc. For some reason, ce51a07 only applies this shift to inputs between 1 and 3 (my guess is IV/V/VI didn't have any vanilla usage at this point), but values over and including 4 are not adjusted.

To clarify: EssentialsX has never enforced an upper limit on potion strengths, and this PR doesn't remove such a limit. Instead, this PR removes the limit on the values that get offset by -1, so that all positive values are adjusted.

Changing this check will change the power applied for all potions in kits, /give, /item and /potion. It's not infeasible for servers to intentionally use levels above 4 with custom language files (or even just vanilla for IV/V/VI), and for that reason I'm not sure that breaking this is the best way to give people access to level IV potions.

I'd prefer we added an alternative syntax that doesn't attempt to offset potion effect strength, as this would avoid breaking existing kits/potions. I've opened #3614 with an implementation of this, which allows you to replace power:<value> with amplifier:<value> to use untranslated amplifier values instead of partially-translated ones.