-
-
Notifications
You must be signed in to change notification settings - Fork 6
GH-140 Bump run server version to 1.21.4 and add old legacy hex color transformers #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CitralFlo
commented
Mar 9, 2025
WalkthroughThe changes update the Minecraft server task configuration in the build file by changing the Minecraft version from "1.20.4" to "1.21.4". Additionally, a new regular expression pattern has been added to the legacy formatting class to match hexadecimal color codes formatted with an "&x" prefix. The processing method in this class now uses the new pattern for converting these color codes into the expected format, while continuing to handle previously supported formats. Furthermore, a new unit test has been introduced to ensure that the conversion from legacy hex formatting to the Adventure format works correctly, enhancing test coverage for this functionality. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Tested with hexNicks (recently user reported issue on discord Support - thankfully hexNicks has placeholder for MiniMessage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gj
… transformers (#144) * Bump run server version to 1.21.4 and add old legacy hex color transformers * Add test for legacy hex formatting