GH-1129 Replace @Context annotation with @Sender where possible

[Jakubk15]

No description provided.

[Jakubk15]

/gemini review

[Copilot]

Pull Request Overview

This PR replaces the @Context annotation with @Sender annotation in command method parameters where the parameter represents the command sender. This is a refactoring effort to use more semantically appropriate annotations for command sender parameters in the LiteCommands framework.

• Systematically replaces @Context Player and @Context CommandSender with @Sender where the parameter represents the command executor
• Updates import statements to include @Sender and remove unused @Context imports where applicable
• Maintains existing @Context usage for other parameters like Viewer, User, and Invocation which represent different contextual data

Reviewed Changes

Copilot reviewed 72 out of 72 changed files in this pull request and generated 3 comments.

File	Description
Command classes (65+ files)	Replace @Context with @Sender for Player/CommandSender parameters representing command executors
Import statements	Add @Sender imports and clean up unused @Context imports where appropriate

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[gemini-code-assist]

Code Review

This pull request correctly refactors the codebase to use the @Sender annotation instead of @Context for injecting the command sender. The changes are consistent across most of the project. However, I've identified a couple of issues. One is a functional regression in TeleportToPositionCommand where a refactoring removed functionality. Another is a minor code clarity issue in SudoCommand. Please see the detailed comments for suggestions.

[gemini-code-assist]

Code Review

This pull request correctly replaces the @Context annotation with the more specific @Sender annotation across multiple command classes, which improves code clarity and adheres to the litecommands library's best practices. The changes are consistent and well-executed. However, I've identified a functional regression in TeleportToPositionCommand where a change in method call removes the feedback message to the player after teleportation, and an unused parameter in SudoCommand. I've provided suggestions to fix these issues.

[CitralFlo]

Why not in every command? IS it not possible elsewhere? ex. Heal command?

More accurate screen:

[vLuckyyy]

If I’m being honest, I really don’t like this change. In my opinion, @Context was a better solution. As I found out, @Sender is just an alias for @Context, but I still don’t really like the idea of these changes. @Context carried more meaning for me, while @Sender feels more like some kind of validator.

[Jakubk15]

Why not in every command? IS it not possible elsewhere? ex. Heal command?

More accurate screen:

I did not implement everywhere in Viewer type as it would cause confusion, for example in method execute(@sender Viewer viewer, @sender CommandSender sender) it just looks bad

I can search for use cases where I can indeed use this annotation for Viewer

[igoyek]

If these are all the cases, it looks ok :)