updated the avatar radius and camera rotation #10118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra Near values updated the camera rotation to use the world rotation
HexaField
requested changes
May 1, 2024
spawn avatar fetches camera's near value from camera component
HexaField
requested changes
May 1, 2024
…he Avatar Controller Component
HexaField
requested changes
May 2, 2024
HexaField
requested changes
May 2, 2024
packages/engine/src/avatar/components/AvatarControllerComponent.ts
Outdated
Show resolved
Hide resolved
MbfloydIR
added a commit
that referenced
this pull request
May 6, 2024
* dev: fix admin projects and build status modals and statuses (#10116) Add unique constraint to project name column (#10125) 9928 optimize asset builds (#9965) Physics API Abstraction (#10124) rework scene loaded state usage (#10127) Camera and Spectation are Event Sourced (#10130) Location GLTF State Cleanup (#10129) Add locationType menu (#10128) IR 465 ECS Materials (#10109) Fix scenestate references in playmode tool (#10126) Remove old ColliderComponent (#10122) GLTF ECS Loader (#10102) Systems without any pre/post/sub systems will no longer start out expanded (#10120) Updated the avatar radius and camera rotation (#10118) Fixed setup helm in dev-deploy (#10092) Fix interactable cursor style reactor (#10117) IR-1790 making the addComponent search box gain focus automatically when opening the addComponent popup (#10106) Update AddEditLocationModal.tsx (#10110) Update README.md (#10112) MountPoint/Grabbable/Link Components now add Interactables to the authoring layer, optimized useEffects to Systems/Components/Editors (#10105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
updated the camera rotation to use the world rotation
updated the avatar radius to be the sum of the eyeOffset and the camera Near values
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps