Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

IR-1780 Interactables serializing and mounting cleanup #10105

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

SamMazerIR
Copy link
Contributor

@SamMazerIR SamMazerIR commented Apr 30, 2024

Summary

MountPoint/Grabbable/Link Components now add Interactables to the authoring layer, optimized useEffects to Systems/Components/Editors

proper serialization of InteractableComponents added by other components proper serialization of all remaining elements of Interactables proper editor callback selection on self for Interactables and Triggers

Subtasks Checklist

References

IR-1780

QA Steps

  1. Add a new entity to a scene, add a component of one of the following: MountPoint, Link, Grabbable.
  2. Observe that it will have also added an InteractableComponent
  • note that the default callback is now properly selecting "Self" and the corresponding callback option from your chosen component is chosen as a dropdown option rather than a string (this is now also true for TriggerComponent if there are callbacks on the same entity you add it to)
  • image
  1. Modify any properties of the InteractableComponent and save the scene
  2. either view the scene source or publish and play the scene, your changes to the InteractableComponent should now be reflected properly
  • image

…horing layer, optimized useEffects to Systems/Components/Editors

proper serialization of InteractableComponents added by other components
proper serialization of all remaining elements of Interactables
proper editor callback selection on self for Interactables and Triggers
@SamMazerIR SamMazerIR changed the title Interactables serializing and mounting cleanup IR-1780 Interactables serializing and mounting cleanup Apr 30, 2024
Copy link
Member

@AidanCaruso AidanCaruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. XRUI labels aren't appearing inside the activation threshold anymore, but that's not related to this PR. Probably should look into that at some point

@speigg speigg added this pull request to the merge queue Apr 30, 2024
Merged via the queue into dev with commit e800a18 Apr 30, 2024
13 checks passed
@speigg speigg deleted the IR-1780-dynamic-interactable-serialization branch April 30, 2024 22:08
MbfloydIR added a commit that referenced this pull request May 6, 2024
* dev:
  fix admin projects and build status modals and statuses (#10116)
  Add unique constraint to project name column (#10125)
  9928 optimize asset builds (#9965)
  Physics API Abstraction (#10124)
  rework scene loaded state usage (#10127)
  Camera and Spectation are Event Sourced (#10130)
  Location GLTF State Cleanup (#10129)
  Add locationType menu (#10128)
  IR 465 ECS Materials (#10109)
  Fix scenestate references in playmode tool (#10126)
  Remove old ColliderComponent (#10122)
  GLTF ECS Loader (#10102)
  Systems without any pre/post/sub systems will no longer start out expanded (#10120)
  Updated the avatar radius and camera rotation (#10118)
  Fixed setup helm in dev-deploy (#10092)
  Fix interactable cursor style reactor (#10117)
  IR-1790 making the addComponent search box gain focus automatically when opening the addComponent popup (#10106)
  Update AddEditLocationModal.tsx (#10110)
  Update README.md (#10112)
  MountPoint/Grabbable/Link Components now add Interactables to the authoring layer, optimized useEffects to Systems/Components/Editors (#10105)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants