Fix bug where selecting a row while filtered would lose all other rows #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#170
Before, we would copy all visible rows over with just the modified row having toggled its select. However, when filtered, the visible rows did not include all the filtered-out rows, so they would be lost.
Now we keep an internal ID on all rows. This may also be useful in the future, but it's particularly useful to allow us to find the selected row and toggle its selection directly in the underlying row structure. This is also quicker and requires less copying, which is a bonus, despite being a simple linear search.