Refactor how config routes are deleted from outgoing RIB to handle offline routers #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2022 07:58
|
I have merged the patch but now wonder if there will be an issue with API routes? I need to check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #1126.
Previously the old routes from the configuration were deleted from the peer reactor, leading to the RIB become out of date if the neighbor was offline when an update or sequence of updates was made.
Refactored to this so that any deleted configuration routes are removed from RIB during configuration reload rather than from the reactor.
Tested this with a variety of normal and FlowSpec routes and the RIB is correct all configuration reloads.
I have run all the QA functional tests successfully.