Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT5 support changes for exaBGP #256

Merged
merged 2 commits into from
May 10, 2015
Merged

Conversation

garci66
Copy link
Contributor

@garci66 garci66 commented May 10, 2015

Here are the changes I have written. I had not submitted them before because I believe there is some issue when the class tries to register the route parser. Right now, neither RT2 or RT5 can be registered it seems (but the EVPN adjacency forms fine).

I had no time to debug it but I believe its a good start. And looks like the code can still be merged quite straightforwardly!

@landscape-bot
Copy link

Code Health
Repository health increased by 0.14% when pulling ae5b5fa on garci66:master into f6baba2 on Exa-Networks:master.

@thomas-mangin
Copy link
Member

@garci66 - Thanks a lot - Could I ask you if you could rebase on my tree, as the merge will otherwise fail. If it is too hard, I will try to get git to do my binding 😄

@garci66
Copy link
Contributor Author

garci66 commented May 10, 2015

Willing to help.. but just need a tip on how to do it. Is it just git rebase? I guess I need to add this repo (instead of my fork) as a master

@thomas-mangin
Copy link
Member

... I was asking as I do not know myself ...
I tried to apply the patches to my branch but it failed as there is some conflicts due to some thing being renamed/moved. I can apply your changes "by hand" if it is not easy for you- I will just pretend to be you so credit is well kept 😉

@garci66
Copy link
Contributor Author

garci66 commented May 10, 2015

at least here it tells me the changes can be merged automatically (to your master here in exa). Is it not the master branch you're committing to? (sorry.. im a networking person, not really into git so im playing by ear here)...

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.29% when pulling d3660da on garci66:master into f6baba2 on Exa-Networks:master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.29% when pulling 708c8b5 on garci66:master into f6baba2 on Exa-Networks:master.

@thomas-mangin thomas-mangin merged commit 708c8b5 into Exa-Networks:master May 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants