Skip to content

feature/SOF-7524 B-vacancy hBN #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 28, 2024
Merged

feature/SOF-7524 B-vacancy hBN #187

merged 4 commits into from
Dec 28, 2024

Conversation

VsevolodX
Copy link
Member

  • feat: add vacncy in hbn nb
  • update: fix description and reproduce

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

timurbazhirov
timurbazhirov reviewed Dec 28, 2024
View reviewed changes
other/materials_designer/specific_examples/defect_point_vacancy_boron_nitride.ipynb
@@ -0,0 +1,291 @@
{
Copy link
Member

@timurbazhirov timurbazhirov Dec 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should explain the units for the length. Same - for coordinate


Reply via ReviewNB

@VsevolodX VsevolodX merged commit 06642f7 into dev Dec 28, 2024
4 checks passed
@VsevolodX VsevolodX deleted the feature/SOF-7524 branch January 4, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timurbazhirov timurbazhirov timurbazhirov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VsevolodX @timurbazhirov