feature/SOF 7685 #238
Merged
feature/SOF 7685 #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
VsevolodX
commented
Aug 7, 2025
VsevolodX
commented
- update: imports from top level helpers
- update: heterostructure nb
- update: imports
- update: improt made
- update: slab related
- update: imports in specific examples (claude)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -1,7 +1,11 @@ | |||
| { | |||
| "cells": [ | |||
There was a problem hiding this comment.
Line #1. from mat3ra.made.tools.modify import wrap_to_unit_cell
Remove wrap_to_unit_cell
Reply via ReviewNB
| "\n", | ||
| "Set the following flags to control the notebook behavior.\n" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Line #5. await micropip.install("https://exabyte-io.github.io/api-examples/mat3ra_api_examples-0.1.dev1+g03efa43-py3-none-any.whl", deps=False)
This NB needs to be adjusted similar to the one in specific_examples
Reply via ReviewNB
| @@ -1,7 +1,11 @@ | |||
| { | |||
| "cells": [ | |||
There was a problem hiding this comment.
| "## 1. Prepare the Environment\n", | ||
| "### 1.1. Set up defects parameters \n", | ||
| "Defect Configuration parameters are described in [Defect Configuration](https://github.com/Exabyte-io/made/blob/8196b759242551c77d1791bf5bd2f4150763cfef/src/py/mat3ra/made/tools/build/defect/configuration.py#L102)." | ||
| ] |
There was a problem hiding this comment.
| "## 1. Prepare the Environment\n", | ||
| "### 1.1. Set up defects parameters \n", | ||
| "Defect Configuration parameters are described in [Defect Configuration](https://github.com/Exabyte-io/made/blob/8196b759242551c77d1791bf5bd2f4150763cfef/src/py/mat3ra/made/tools/build/defect/configuration.py#L102)." | ||
| ] |
There was a problem hiding this comment.
| "cell_type": "markdown", | ||
| "id": "3ae4cc7db0846f04", | ||
| "metadata": { | ||
| "collapsed": false |
There was a problem hiding this comment.
Line #7. MaterialWithBuildMetadata.create(Materials.get_by_name_first_match(STRUCTURE_PARAMS[0].name)),
Lets just do this for all the STRUCTURE_PARAMS members, e.g. crystals = [MaterialWithBuildMetadata.create(Materials.get_by_name_first_match(parameter.name)) for parameter in STRUCTURE_PARAMETERS]
Reply via ReviewNB
| @@ -1,7 +1,11 @@ | |||
| { | |||
| "cells": [ | |||
There was a problem hiding this comment.
timurbazhirov
approved these changes
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.