Bugfix/sof 5578 wip - Make Colab Great Again #71
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mrakitin
force-pushed
the
bugfix/SOF-5578-WIP
branch
from
991e932
to
598a4c8
Compare
…abyte-api-examples`
- get-file-from-job.*
- ml-train-model-predict-properties.*
- get_authentication_params.*
…nitialize_settings.py`
Just a reminder for myself and reviewers that the command above needs to be run to fix the branch before merging to |
Update the other files which weren't mentioned in the PR review: - README.md - examples/job/create_and_submit_job.* - examples/job/run-simulations-and-extract-properties.* - examples/material/api_interoperability_showcase.* - examples/material/create_material.* - examples/material/get_materials_by_formula.* - examples/material/import_materials_from_materialsproject.* - examples/material/import_materials_from_poscar.* - examples/workflow/get_workflows.*
…sed to the script as positional arguments
| @@ -89,5 +122,6 @@ def execute(): | |||
| set_notebook_environment(environment_variables_config) | |||
|
|
|||
|
|
|||
| execute() | |||
| os.environ.update({"is_setup_executed": "True"}) | |||
| if __name__ == "__main__": | |||
There was a problem hiding this comment.
Minor thing, initialize_settings.py isn't being executed directly anymore in notebooks, we could remove it altogether
There was a problem hiding this comment.
@mrakitin - should we remove it?
There was a problem hiding this comment.
Thanks for your review, @chu-k!
I defined a couple of functions that are used in CLI and in some notebooks, but not the old execute() one. I can move those to __init__.py if people are OK with it, and then the initialize_settings.py can be removed.
There was a problem hiding this comment.
Let's remove unused functions and rename this file to notebook.py maybe?
… from unused functions
…from the cleaned up `initialize_settings.py`)
|
All review comments have been addressed, ready for final review, before I update the branch (#71 (comment)). |
|
This can be merged |
|
Merged, thanks, All! |
No description provided.