Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a damping_driver documentation and updated the index and refere… #172

Merged
merged 6 commits into from
Oct 25, 2021

Conversation

rosscastle
Copy link
Contributor

…nce files.

@rosscastle rosscastle added docs phys:drag Physics: surface drag and gravity waves labels Jul 15, 2020
Copy link
Contributor

@matthewjhenry matthewjhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, Ross!:)
Realised at the end that I was QC and not editor, might as well submit my comments.
A few minor language/typo type edits. I haven't used the module before, so can't really comment on the science aspect.

docs/source/modules/damping_driver.rst Outdated Show resolved Hide resolved
docs/source/modules/damping_driver.rst Outdated Show resolved Hide resolved
docs/source/modules/damping_driver.rst Outdated Show resolved Hide resolved
docs/source/modules/damping_driver.rst Outdated Show resolved Hide resolved
docs/source/modules/damping_driver.rst Outdated Show resolved Hide resolved
docs/source/modules/damping_driver.rst Outdated Show resolved Hide resolved
docs/source/modules/damping_driver.rst Outdated Show resolved Hide resolved
docs/source/modules/damping_driver.rst Outdated Show resolved Hide resolved
docs/source/modules/damping_driver.rst Outdated Show resolved Hide resolved
docs/source/modules/damping_driver.rst Outdated Show resolved Hide resolved
rosscastle and others added 5 commits July 18, 2020 12:36
Namelist options Captital R on Rayleigh x2 (start and end)

Rayleigh drag explaination typo toward. Also capital R on rayliegh

Constant drag typo modelled and calculate.

Stephens name.
Title changed to more readable format.

_ added to ``damping driver`` in first line of text

Added file location to Summary

Sorted error on ``1 to kbot`` for Rayleight Drag.

Simplification in module choice simplification: A blabla module (name) may be called (optional). I added optional above as it applied to all.

Topo_drag reference clarification.

Full stop line 25.

Typo: exception

Rewrote Rayliegh drag explaination

Comma added line 124

Earth set up rewritten.
Typos spotted from last read through.
@rosscastle
Copy link
Contributor Author

Hi @matthewjhenry, I've updated this (only taken me 16 months to do 5 mins worth of work!) and it's good to go, all changes have been made.

@matthewjhenry matthewjhenry merged commit cbfb749 into ExeClim:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs phys:drag Physics: surface drag and gravity waves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants