-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for idealised_moist_phys.F90 #173
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RuthG
added
docs
phys:const
Physics: constants, astronomy, condensate saturation
phys:conv
Physical parameterisations: convection
phys:diff
Physical parameterisations: turbulence, diffusion, smoothing
phys:drag
Physics: surface drag and gravity waves
phys:rad
Physics: radiation
phys:sfc
Physics: topography, surface fluxes, bucket hydrology, vegetation
labels
Jul 15, 2020
rosscastle
reviewed
Jul 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ruth, great job! Those tables must have been fun (not)!
A few comments:
- Should we be refering to it as idealized_moist_phys instead of the English way?
- Line 75 typo: compatibility
- Line 110 typo: Additional
- Line 173 typo: initialisation
- Line 231 typo: Available
- You can delete the template stuff
- As you have said references need sorting
- What is RAW? If I am being dumb then just ignore this point.
Note: I haven't checked the math symbols as it's a real pain to download and set up on a windows laptop.
…et clean up current draft
mp586
reviewed
Aug 12, 2020
Just a general comment for us to not forget to include the literature references |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
phys:const
Physics: constants, astronomy, condensate saturation
phys:conv
Physical parameterisations: convection
phys:diff
Physical parameterisations: turbulence, diffusion, smoothing
phys:drag
Physics: surface drag and gravity waves
phys:rad
Physics: radiation
phys:sfc
Physics: topography, surface fluxes, bucket hydrology, vegetation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my progress on documentation for idealised_moist_phys, thoughts and input welcome.
Outstanding issues