Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for idealised_moist_phys.F90 #173

Closed
wants to merge 14 commits into from

Conversation

RuthG
Copy link

@RuthG RuthG commented Jul 15, 2020

Here is my progress on documentation for idealised_moist_phys, thoughts and input welcome.

Outstanding issues

  • A few references need adding to align with those used in other modules
  • I would also like to mention Tapio Schneider's github repo in some way, as that is where I lifted the bucket module code from.

@RuthG RuthG linked an issue Jul 15, 2020 that may be closed by this pull request
@RuthG RuthG added docs phys:const Physics: constants, astronomy, condensate saturation phys:conv Physical parameterisations: convection phys:diff Physical parameterisations: turbulence, diffusion, smoothing phys:drag Physics: surface drag and gravity waves phys:rad Physics: radiation phys:sfc Physics: topography, surface fluxes, bucket hydrology, vegetation labels Jul 15, 2020
Copy link
Contributor

@rosscastle rosscastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ruth, great job! Those tables must have been fun (not)!

A few comments:

  • Should we be refering to it as idealized_moist_phys instead of the English way?
  • Line 75 typo: compatibility
  • Line 110 typo: Additional
  • Line 173 typo: initialisation
  • Line 231 typo: Available
  • You can delete the template stuff
  • As you have said references need sorting
  • What is RAW? If I am being dumb then just ignore this point.

Note: I haven't checked the math symbols as it's a real pain to download and set up on a windows laptop.

docs/source/modules/idealised_moist_phys.rst Show resolved Hide resolved
docs/source/modules/idealised_moist_phys.rst Show resolved Hide resolved
docs/source/modules/idealised_moist_phys.rst Show resolved Hide resolved
docs/source/modules/idealised_moist_phys.rst Show resolved Hide resolved
docs/source/modules/idealised_moist_phys.rst Show resolved Hide resolved
docs/source/modules/idealised_moist_phys.rst Show resolved Hide resolved
docs/source/modules/idealised_moist_phys.rst Show resolved Hide resolved
docs/source/modules/idealised_moist_phys.rst Show resolved Hide resolved
docs/source/modules/idealised_moist_phys.rst Show resolved Hide resolved
docs/source/modules/idealised_moist_phys.rst Show resolved Hide resolved
@mp586
Copy link
Contributor

mp586 commented Sep 23, 2020

Just a general comment for us to not forget to include the literature references

@RuthG RuthG closed this Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs phys:const Physics: constants, astronomy, condensate saturation phys:conv Physical parameterisations: convection phys:diff Physical parameterisations: turbulence, diffusion, smoothing phys:drag Physics: surface drag and gravity waves phys:rad Physics: radiation phys:sfc Physics: topography, surface fluxes, bucket hydrology, vegetation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idealized_moist_phys
3 participants