-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two stream gray docs #176
Two stream gray docs #176
Conversation
Conflicts: src/extra/python/isca/experiment.py
Hi Neil, I've just taken a quick look over this, the structure and description of what each scheme does look good to me! Just a few typos to flag up: |
Hi Ruth,
Thanks for taking a look, are you happy to approve this once these changes have been made or would you rather look over it in more detail at some point?
While I correct the typos I’ll also have another look through to see if there are any that have evaded both of us!
Neil
On 20 Jul 2020, at 14:16, RuthG <notifications@github.com> wrote:
Hi Neil,
I've just taken a quick look over this, the structure and description of what each scheme does look good to me! Just a few typos to flag up:
l35: available
l37: available
l202: diurnal
l402: calculations
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#176 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHHIWPSH6LYLPPS3KNYQZZTR4Q7SNANCNFSM4O4TSGWA>.
|
Hi Neil,
Something I just thought of - I’ll do a quick check whether the default parameters in the Geen scheme are the version I think should be stable with the slab ocean, and we can add a recommendation (or perhaps change the defaults in the master) if not. I’ll also remind myself what variations around BoG we’ve tried over the years and check that against the model defaults and BoG paper.
I will find a moment to do all that by the weekend, and let you know what I find and if I think any comment should be added about those namelist choices.
Aside from that I’d be happy to approve it, I think it covers all the key points, I don’t see any code/science problems and it explains what is going on clearly. Matthew’s down as quality control, so that will give a second pair of eyes on it.
Thanks for writing it!
Ruth
On 20 Jul 2020, at 18:38, Neil Lewis <notifications@github.com<mailto:notifications@github.com>> wrote:
CAUTION: This email originated from outside of the organisation. Do not click links or open attachments unless you recognise the sender and know the content is safe.
Hi Ruth,
Thanks for taking a look, are you happy to approve this once these changes have been made or would you rather look over it in more detail at some point?
While I correct the typos I’ll also have another look through to see if there are any that have evaded both of us!
Neil
On 20 Jul 2020, at 14:16, RuthG <notifications@github.com<mailto:notifications@github.com>> wrote:
Hi Neil,
I've just taken a quick look over this, the structure and description of what each scheme does look good to me! Just a few typos to flag up:
l35: available
l37: available
l202: diurnal
l402: calculations
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#176 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHHIWPSH6LYLPPS3KNYQZZTR4Q7SNANCNFSM4O4TSGWA>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FExeClim%2FIsca%2Fpull%2F176%23issuecomment-661228561&data=02%7C01%7CR.Geen%40exeter.ac.uk%7Cf285ce80f22842da462308d82cd3ae80%7C912a5d77fb984eeeaf321334d8f04a53%7C0%7C0%7C637308634955553303&sdata=%2BhhvYZU7BpRHRnBg0Uqz089BeCaGQKEfrGvTfNGMSQc%3D&reserved=0>, or unsubscribe<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD7AJPSZSNEVGYT7YONXZYDR4R6H3ANCNFSM4O4TSGWA&data=02%7C01%7CR.Geen%40exeter.ac.uk%7Cf285ce80f22842da462308d82cd3ae80%7C912a5d77fb984eeeaf321334d8f04a53%7C0%7C0%7C637308634955553303&sdata=WtIJhwyIT%2BE1aXC8N49VY6mDd2sStE8qgpfyH33J%2FbM%3D&reserved=0>.
|
Great job @ntlewis and @RuthG. This is very thorough and helpful documentation! :) Happy to push when these comments are considered (some are mere suggestions). Comments:
|
…into two_stream_gray_docs
Hi @matthewjhenry and @RuthG, I've corrected each of the typos you spotted. Ruth: I haven't yet done anything regarding the hard coding of the BOG CO2 coeff, or the possibility to include Ozone in the Geen scheme. As neither of these changes have been made to the code yet, I've left any changes relating to them out of the docs. I have, however, included a note saying that the Geen scheme is only stable for fixed SSTs. I think this is ready to go now, once the Travis check passes and you guys approve it. Would be good to get it in soon :) Neil |
Could you change the GEEN expected by to 30/11/2020 please! There's not much work needed but I've got a lot of commitments the next couple of months and would rather not set myself up to fail immediately here!
|
@RuthG occurrences of date changed. Feel free to merge once the Travis build has passed again. |
This PR addresses issue #132 by adding documentation for two_stream_gray_rad.