Fixed line length nml fix #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumn widths for string variables when writing out nml files. The default line width is 72 characters. The default is the same in previous versions of f90nml, but did not seem to be enforced. This has the effect of splitting some variables across multiple lines in input.nml, causing the model to fail when these are read. An example case is socrates_rad_nml with the lw_spectral_filename parameter pointing to a directory that is generally longer than 72 characters. I have modified the python front end to allow for a maximum width of 350. This is longer than the 256 characters this namelist parameter has as its own maximum, therefore leaving room for long variable names too.
dennissergeev
requested changes
Aug 4, 2020
|
Thanks for the review @dennissergeev - and you're right that it'd be good to get us conforming to these standards. Hopefully the changes I've just made look alright. |
dennissergeev
approved these changes
Aug 4, 2020
|
Looks like the build has passed OK, so I'll merge this in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of
f90nmlavailable on pip, v1.2, enforces fixed-column widths for string variables when writing out nml files. The default line width is 72 characters. The default is the same in previous versions off90nml, but did not seem to be enforced. This has the effect of splitting some variables across multiple lines ininput.nml, causing the model to fail when these are read. An example case issocrates_rad_nmlwith thelw_spectral_filenameparameter pointing to a directory that is generally longer than 72 characters. I have modified the python front end to allow for a maximum width of 350. This is longer than the 256 characters this namelist parameter has as its own maximum, therefore leaving room for long variable names too.