Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for RRTM Radiation #181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

RuthG
Copy link

@RuthG RuthG commented Aug 12, 2020

Documentation and references for rrtm_radiation.f90 following the structure used for SOCRATES documentation.

@RuthG RuthG added phys:rad Physics: radiation priority:high High-priority task docs labels Aug 12, 2020
@ntlewis
Copy link
Contributor

ntlewis commented Sep 23, 2020

Hi @RuthG,

Going to try and take a look at this today or tomorrow.

Neil

Copy link
Contributor

@matthewjhenry matthewjhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two very minor comments, the rest is clear and very straight-forward. Nice job!:)

+----------------------------+----------+---------------------------------------------------------------------------------------------------------+
| Name | Default | Description |
+============================+==========+=========================================================================================================+
| ``dt_rad`` | 0 | Radiation timestep - every step if ``dt_rad<dt_atmos`` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the "every step if dt_rad<dt_atmos" part, maybe rephrase?

+----------------------------+----------+---------------------------------------------------------------------------------------------------------+
| ``dt_rad_avg`` | -1 | If averaging, over what time? ``dt_rad_avg=dt_rad`` if ``dt_rad_avg<=0`` |
+----------------------------+----------+---------------------------------------------------------------------------------------------------------+
| ``lonstep`` | 1 | Allows subsampling of fields along longitude for faster radiation calculation |
Copy link
Contributor

@matthewjhenry matthewjhenry Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if lonstep not equal 1?

@rosscastle rosscastle removed priority:high High-priority task phys:rad Physics: radiation labels Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants