Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idealised moist docs #187

Merged
merged 16 commits into from
Sep 30, 2020
Merged

Idealised moist docs #187

merged 16 commits into from
Sep 30, 2020

Conversation

RuthG
Copy link

@RuthG RuthG commented Sep 23, 2020

Here are the corrections to my previous pull request.
Apologies for the new branch, I decided to rename my local branch and this seems to have caused some problems with the remotes.

@mp586
Copy link
Contributor

mp586 commented Sep 30, 2020

are we supposed to add an Authors section or is that optional?

Copy link
Contributor

@rosscastle rosscastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really really nice!

I think the only issue I can find is that the file itself (and therefore in the index) has idealized spelt with an s (correctly) not a z (as per the model code), but I think we can ignore this!

@RuthG
Copy link
Author

RuthG commented Sep 30, 2020

Thanks for checking it, I've added the authors at the bottom, I forgot about that. Happy to merge?

@rosscastle
Copy link
Contributor

Thanks for checking it, I've added the authors at the bottom, I forgot about that. Happy to merge?

Merge time!

@mp586
Copy link
Contributor

mp586 commented Sep 30, 2020

yes! :)

@RuthG RuthG merged commit 2283cca into ExeClim:master Sep 30, 2020
@RuthG RuthG deleted the idealised_moist_docs branch September 30, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants