Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giant Planet Test Case "Bug" fix #193

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Conversation

rosscastle
Copy link
Contributor

As agreed with ST, after problems spotted by DW, the giant planet tes…t case crashes due to a memory problem. This crash happens on GV5 and ISCA HPC, therefore we assume it happens on most machines. It does not happen on the trip tests because this test case is set to a lower resolution for these. To ensure the test case works out of the box, we increase the stack size (and number of cores, as it was very slow). The original version did say in the fms namelist that the stack size should be increased for high res runs, but there is no error pointing to this.

…t case crashes due to a memory problem. This crash happens on GV5 and ISCA HPC, therefore we assume it happens on most machines. It does not happen on the trip tests because this test case is set to a lower resolution for these. To ensure the test case works out of the box, we increase the stack size (and number of cores, as it was very slow). The original version did say in the fms namelist that the stack size should be increased for high res runs, but there is no error pointing to this.
@rosscastle
Copy link
Contributor Author

Test passed for giant_planet. Commit d836edf gives the same answer as commit 6216a21
Results for all of the test cases ran comparing 6216a21 and d836edf are as follows...
giant_planet : pass
Congratulations, all tests have passed

Copy link
Contributor

@sit23 sit23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks @rosscastle and Dan

@rosscastle rosscastle merged commit 8f7514f into ExeClim:master Nov 10, 2020
@rosscastle rosscastle deleted the GPTC_fix branch November 10, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants