Isca Structure Documentation #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6 GFDL spectral model. Includes 2 .png diagrams. Index file modified.
rosscastle
added
docs
priority:high
penmaher
requested changes
Feb 24, 2021
There was a problem hiding this comment.
Hi Ross. Looks really great and is easy to understand. a few minor comments just to help clarity or to add a couple of things here and there. I have posted the Isca image on the Slack channel as I want everyone to run their eye over it. This increases the odds of people finding problems with it. Let me know when it is ready to be reviewed again. Penny
…text. Main diagram changed for clearer gray radiation call and LLCS added.
|
Thanks PM, NL and MH for comments. I have made all changes suggested. Still need to talk to RG about the branch coming off the surface flux box. |
Compiler note added (not worth opening up a separate PR).
|
Hey Ross. Changes look good. I suspect this is the sort of thing we update along the way, but nothing sticks out for me. Happy for it to go in the docs. |
penmaher
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation page on the structure of Isca and comparison to the 2006 GFDL spectral model. Includes 2 .png diagrams. Index file modified.
1st draft is complete.