-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalisation of atmospheres for use on non-Earth/exoplanet systems #203
base: master
Are you sure you want to change the base?
Conversation
…for non-water generalisation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice fixes, I can't see anything wrong. I have some questions:
- two_stream_gray_rad.F90 L424: Is it possible (perhaps as a later project) to be able to use the day_in_sec option rather than using an Earth day (86400)?
- idealised_most_phys.F90 L427-429: Is this the trip test issue you were fixing?
surface_flux is a simple rename, so that's fine. sat_vapour_press fine, took me a second to get round the "double variables" but this does make sense. Same for constants.
Will go back through the docs PR now.
Yes, the change to Regarding your comment on One change I'm considering is changing the variable name of |
Makes sense
Yeah that makes sense, future project maybe. I feel like it'll be a big one to sort out all the calendars etc.
Yeah good idea. Or |
Currently a number of modules within Isca are hard-coded for use on Earth, a throwback to its initial development as the GFDL model. The result is that moist physics processes currently only work for atmospheres with water as the primary condensate, whilst objects that rotate very slowly compared to Earth (e.g. Titan and Venus) are not correctly modelled without modifications to the code.
This PR aims to address these shortcomings by introducing a more generalised form for moist atmospheres, allowing the use of alternative condensates (e.g. methane on Titan), which allows for the modelling of a wider range of planetary systems including exoplanets. This is controlled by new namelist parameters in the
constants.f90
file -- the documentation for which can be found in PR #198 .Further, a modification is made to allow very slowly rotating objects to be modelled correctly (under the current Isca these systems are falsely modelled as being tidally-locked). This is accompanied by the addition of a new namelist parameter that allows the rotation period to be specified directly (rather than as a rotation rate).