Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAS output problems #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RAS output problems #212

wants to merge 1 commit into from

Conversation

sit23
Copy link
Contributor

@sit23 sit23 commented Jun 16, 2021

The problem

Recently it was reported that there were issues with the diagnostic outputs from the RAS modules (the scheme itself seems to run fine). The problems were that the output appeared different depending on the number of cores used, and it was clearly non-hemispherically symmetric, even when the setup was symmetric in other senses.

The fix
Old 2006 FMS version requires is, js, and sometimes ks to be supplied to send_data. More recent FMS, upon which Isca is based, seems to not want these variables to be passed, and runs better without them. The old syntax was still being used in RAS, so problems were reported with the outputs. This commit corrects this problem, and the outputs are much improved.

… to send_data. More recent FMS, upon which Isca is based, seems to not want these variables to be passed, and runs better without them. The old syntax was still being used in RAS, so problems were reported with the outputs. This commit corrects this problem, and the outputs are much improved.
@sit23 sit23 added bug phys:conv Physical parameterisations: convection labels Jun 16, 2021
@sit23
Copy link
Contributor Author

sit23 commented Jun 16, 2021

Trip tests are passing, so I think this is safe to merge in.

Results for all of the test cases ran comparing 75880af and 2b603fa are as follows...
axisymmetric : pass
bucket_model : pass
frierson : pass
giant_planet : pass
held_suarez : pass
MiMA : pass
realistic_continents_fixed_sst : pass
realistic_continents_variable_qflux : pass
socrates_aquaplanet : pass
top_down_test : pass
variable_co2_grey : pass
variable_co2_rrtm : pass
ape_aquaplanet : pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug phys:conv Physical parameterisations: convection trip tests passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant