Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Coordinate Docs #214

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Vertical Coordinate Docs #214

wants to merge 7 commits into from

Conversation

daw538
Copy link
Contributor

@daw538 daw538 commented Jun 30, 2021

First draft of docs page for the vert_coordinate.f90 module, used to control the model levels used in a run.

Suggestions/improvements welcome, especially if you spot a typo.

@daw538 daw538 added docs priority:medium Medium-piority task core Core modules of Isca (including time managers) labels Jun 30, 2021
@daw538 daw538 requested a review from sit23 June 30, 2021 08:57
@daw538 daw538 assigned daw538 and unassigned daw538 Jun 30, 2021
sit23
sit23 previously requested changes Jul 30, 2021
Copy link
Contributor

@sit23 sit23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great Dan, nice work. I've made a few suggestions, but they're relatively minor. One other thing you might say is to note that the output of the model is on the levels you prescribe in this module (i.e. on sigma levels if you ask for sigma), and therefore it needs to be interpolated to standard pressure levels for interpretation. You could then link to any interpolator documentation should this exist already, or point to it being forthcoming.

docs/source/modules/vert_coordinate.rst Outdated Show resolved Hide resolved
docs/source/modules/vert_coordinate.rst Show resolved Hide resolved
docs/source/modules/vert_coordinate.rst Outdated Show resolved Hide resolved
@daw538
Copy link
Contributor Author

daw538 commented Aug 2, 2021

Thanks Stephen for the feedback -- think I've manged to address and integrate everything you've suggested into the new version.

@daw538 daw538 requested a review from ntlewis October 7, 2021 12:24
@rosscastle rosscastle removed priority:medium Medium-piority task core Core modules of Isca (including time managers) labels Apr 6, 2022
@daw538 daw538 dismissed sit23’s stale review August 4, 2022 09:12

Points raised in initial review have now been address. Closing to allow merge into master.

@daw538 daw538 requested a review from sit23 August 4, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants