Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate v_10m in idealized_moist_phys.F90 #220

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Allocate v_10m in idealized_moist_phys.F90 #220

merged 1 commit into from
Aug 27, 2021

Conversation

RuthG
Copy link

@RuthG RuthG commented Aug 26, 2021

Allocation of v_10m was deleted during cleaning of initials from code causing segfaults when code is compiled with gfortran. This bug fix corrects this deletion.

With this fix the code compiles and runs with gfortran. Trip tests are running now.

…, causing segfaults when code is compiled with gfortran. This bug fix corrects this deletion
@RuthG
Copy link
Author

RuthG commented Aug 27, 2021

I'll check again if the ifort licences are working but I can only trip-test with gfortran. As such anything that calls the moist codebase fails because gfortran can't run the code with the buggy commit.

I also ran into another issue having started a new isca_env with miniforge - somewhere in running the trip test code it crashed, asking for netcdf4 and scipy libraries, which are not included as standard with miniforge. These don't seem to be used in the trip test script so not sure what's up with that, but it may be we want to add these to the installation requirements.

Copy link
Contributor

@sit23 sit23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a brilliant spot - great detective work @RuthG!!

@sit23
Copy link
Contributor

sit23 commented Aug 27, 2021

I'm not sure why the trip tests should be wanting scipy or netcdf4, unless they're required by something else? Can you post the error message? I know xarray reads netcdfs with either scipy or netcdf4 engines, so perhaps it's related to that?

@RuthG
Copy link
Author

RuthG commented Aug 27, 2021

It was in screen and I've lost the error message, but I'll see if I can replicate it in a fresh conda environment once I'm done with the trip tests.

@RuthG
Copy link
Author

RuthG commented Aug 27, 2021

Trip test results

Moist cases crash if I use the buggy commit, but they succeed if I use the commit prior to the bug.
held_suarez is fine.

Possible gfortran specific issues:
axisymmetric crashes with a nml error in both cases
giant_planet produces a different result every time so tests are uninformative
top_down_test crashes with a seg fault

I've not tested Socrates versions as I don't have this installed on Baikonur, but this allocation change shouldn't cause problems. I'll merge it for now so the HEAD runs when compiled with gfortran in most cases, and then look at what's going on with the remaining cases.

@RuthG RuthG closed this Aug 27, 2021
@RuthG RuthG reopened this Aug 27, 2021
@RuthG RuthG merged commit 4006f44 into master Aug 27, 2021
@RuthG RuthG deleted the v_10m_bugfix branch August 27, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants