Update mkmf file to fix gfotran compile issue #236
Conversation
Github test does not compile on master due to compiler issue, this should fix
seems to be some sort of syntax issue, will this fix?
dennissergeev
added
priority:high
|
Ok so it's fixed the first error, but now there's a load of type errors. I'll try to work on this over the next month, although in my opinion it low priority for me as I think it's related to the compiler that the tests are using, but not those that we actually use in Exeter to compile the model, and I need to get on with some other work. Obviously this does need to be fixed at some point, and I'll do my best to do so. |
dennissergeev
added
priority:medium
There was a problem hiding this comment.
Even though these options are discouraged by the GCC devs, I am happy to approve this for now. In the long run, the relevant errors should be fixed (see #237).
There was a problem hiding this comment.
Thanks for doing this @ntlewis. As @dennissergeev says, this isn't the ideal fix, but it will do for now. Fixing all those type-conversion errors in particular is going to take a long time. Perhaps something for some RSE time if we ever get it. But for now let's approve this.
Github test does not compile on master due to compiler issue, this should fix