Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thermodynamic sea ice code #266

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

ntlewis
Copy link
Contributor

@ntlewis ntlewis commented May 31, 2024

Adds thermodynamic sea ice code following Zhang et al. (2022).

Test case can be found here: exp/test_cases/thermodynamic_sea_ice/grey_thermo_ice_test_case.py

@ntlewis ntlewis requested review from sit23 and daw538 May 31, 2024 12:36
@ntlewis
Copy link
Contributor Author

ntlewis commented May 31, 2024

@sit23 @daw538 Would it be possible for one of you guys to take a look at this at some point? Thanks :)

!s Adding relative humidity calculation so as to allow comparison with Frierson's thesis.

if(id_rh >0) then
call rh_calc (p_full(:,:,:,previous),tg_tmp,qg_tmp,RH)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the function call meant to be inside the if statement all along then??

@daw538
Copy link
Contributor

daw538 commented Sep 13, 2024

Broadly looks fine to me. Most of the code is adding functionality rather than editing the existing model so happy to okay if it works as intended.

Probably don't need the lines that comments simply stating !ntl added as this would hopefully be self-evident from the diff in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants