-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thermodynamic sea ice code #266
base: master
Are you sure you want to change the base?
Conversation
!s Adding relative humidity calculation so as to allow comparison with Frierson's thesis. | ||
|
||
if(id_rh >0) then | ||
call rh_calc (p_full(:,:,:,previous),tg_tmp,qg_tmp,RH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the function call meant to be inside the if statement all along then??
Broadly looks fine to me. Most of the code is adding functionality rather than editing the existing model so happy to okay if it works as intended. Probably don't need the lines that comments simply stating |
Adds thermodynamic sea ice code following Zhang et al. (2022).
Test case can be found here: exp/test_cases/thermodynamic_sea_ice/grey_thermo_ice_test_case.py