Missing namelist-writes to logfile #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previous comment in this pull request states: "Even without closing the pull request, the branch could be merged into master at any time." Now know (from pull request #35) that this is incorrect. If the branch itself is merged, which would include all outstanding commits, then the pull request is closed automatically. If not completely merged (e.g. up to some commit that is not the last commit), it would presumably stay open. |
|
So we may need to close this pull request, if we want to merge the first (and if it remains the only) commit |
|
Closed for pending release; reopen later for any additional namelists (cf. list above) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for adding missing namelist-writes to the logfile. Here is my best attempt at the list (which I've checked as far as it goes, but may be incomplete):
badType1_nml
badType2_nml
constants_nml
horiz_interp_spherical_nml
interpolator_nml
missingVar_nml
qflux_nml
test_axis_utils_nml
test_horiz_interp_nml
test_nml
Some of these may not matter. The one I was already aware of, constants_nml, is fixed by
f48f4a4, which has been tested (once), and may serve as an example.
This pull request could be left open until they are all done (or all the ones that matter), or closed earlier for convenience. Even without closing the pull request, the branch could be merged into master at any time.