Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_1230_Static_README_0.27 #1232

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

clanmills
Copy link
Collaborator

In response to #1230, I have added 2.18 Static and Shared Libraries to README.md

@piponazo I don't think that I have the correct CMake remedy in the documentation as I haven't really understood issue #1230. Perhaps you can fix it for me and merge the PR into 0.27-maintenance. Thank You.

@clanmills clanmills added this to the v0.27.3 milestone Jun 9, 2020
@clanmills clanmills requested a review from piponazo June 9, 2020 08:35
@clanmills clanmills self-assigned this Jun 9, 2020
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in the review. I think the added piece of documentation is wonderful. I think any developer with some minor CMake experience would know how to deal with the issue described in #1230 given this doc.

@clanmills clanmills merged commit 08cfc8e into 0.27-maintenance Jun 10, 2020
@clanmills clanmills deleted the fix_1230_Static_README_0.27 branch June 10, 2020 15:33
@clanmills clanmills mentioned this pull request Jun 29, 2020
@hwynn
Copy link

hwynn commented Jul 4, 2020

I was looking forward to the new release because of this new documentation. I found it here, but it's not in my fresh clone of the main project. Did it not get added to the master branch?

@clanmills
Copy link
Collaborator Author

I'm not involved with the v0.28 project which is on the 'master' branch. I maintain the 0.27-maintenance branch. I have no idea when this will be merged into 'master'. Here's the road-map for 'master' #1018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants