Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-conan: be more explicit about desired compiler in conan profile #2085

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

piponazo
Copy link
Collaborator

@piponazo piponazo commented Feb 9, 2022

The windows builds suddenly broke in the last hours. It seems to be a conan related problem:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=msvc
compiler.runtime_type=Release
compiler.version=193
os=Windows
os_build=Windows
[options]
[build_requires]
[env]

ERROR: : 'settings.compiler.cppstd' value not defined

I recently noticed that the conan profile autodetection started to find as compiler msvc instead of Visual Studio. I had some problems with that in other projects and I decided to keep using old profiles like this one:

[settings]
os=Windows
os_build=Windows
arch=x86_64
arch_build=x86_64
compiler=Visual Studio
compiler.version=17
build_type=Release
[options]
[build_requires]
[env]

So that is what I am proposing here. To use a profile that we know it works for sure. I'll try to find out in the meantime why this change happened in conan and if we should migrate to msvc.

@piponazo piponazo added the Conan Handle external dependencies via Conan label Feb 9, 2022
@piponazo piponazo self-assigned this Feb 9, 2022
@piponazo
Copy link
Collaborator Author

piponazo commented Feb 9, 2022

Aha! There was a bug report in the conan project about this:
conan-io/conan#10364

Now they are detecting again "Visual Studio" on windows + Visual Studio 2022.

I will take this opportunity to upgrade conan to its latest version (1.45.0).

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #2085 (362cad7) into main (f2385a3) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2085      +/-   ##
==========================================
- Coverage   62.08%   61.87%   -0.22%     
==========================================
  Files          96       96              
  Lines       19153    19059      -94     
  Branches     9798     9782      -16     
==========================================
- Hits        11891    11792      -99     
- Misses       4967     4984      +17     
+ Partials     2295     2283      -12     
Impacted Files Coverage Δ
src/safe_op.hpp 69.23% <0.00%> (-27.65%) ⬇️
include/exiv2/slice.hpp 69.64% <0.00%> (-21.89%) ⬇️
include/exiv2/error.hpp 60.71% <0.00%> (-4.81%) ⬇️
src/utils.cpp 38.46% <0.00%> (-1.93%) ⬇️
include/exiv2/value.hpp 82.68% <0.00%> (-0.56%) ⬇️
src/enforce.hpp 75.00% <0.00%> (+2.77%) ⬆️
src/getopt.cpp 67.30% <0.00%> (+5.76%) ⬆️
include/exiv2/metadatum.hpp 88.88% <0.00%> (+16.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2385a3...362cad7. Read the comment docs.

@piponazo piponazo merged commit 1b90036 into main Feb 9, 2022
@piponazo piponazo deleted the main_fixConan branch February 9, 2022 18:30
piponazo added a commit that referenced this pull request Feb 10, 2022
@piponazo piponazo mentioned this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conan Handle external dependencies via Conan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants