Move compiler flags to unique file #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….cmake). Also define the PSAPI_VERSION only for the exiv2lib target (It's not needed for the rest of targets)
|
Thanks very much for this, Luis. For sure, the CMake code looks better every day. I've successfully built with msvc (2005), Mac, Linux and Cygwin. Looking good. $ make tests isn't working any more, however I think it's because we're building samples/addmoddel and src/exiv2 into different directories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main objective of this Pull Request is to move most of the compiler flags related code to a unique file (instead of having that code spread in different files).
I have removed the old
CMake_msvc.txtfile that was included in several places and running the same macros over and over. That code is now inconfig/compilerFlags.cmakeand it is only configured once for MSVC.I also have found some other small improvements in the CMake code that I could not avoid to fix following the boy-scout rules (Refer to the commit messages to have a closer look to each change).