-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: simplify libintl check #8
Conversation
The previous fixes did not work out for buildroot in all cases as well, this patch fixed the remaining buildroot problem, please test on Cygwin/MacOSX & Co. |
@bkuhls I fixed this a couple of hours ago and tested it on Cygwin/Linux/MacOS-X. |
@bkuhls I've added your code INCLUDE_DIRECTORIES(${Intl_INCLUDE_DIRS}) Thank You very much for this suggestion. |
With current git HEAD as of 4e86c1d the buildroot build still failed without this patch:
PS: I will try 88cf586 now and will report back. |
Build is still broken with 88cf586, I will send a rebased version of this patch
|
I have to go out for 3 hours this morning (and later today). We'll get this fixed today. Thanks for your help. |
According to https://cmake.org/cmake/help/v3.4/module/FindIntl.html the FindIntl module already checks for libintl.so.
rebased patch force-pushed to branch |
I'm new to git and have no idea what the expression "rebased patch force-pushed to branch" means, however I've accepted your patch and it's working fine on MacOS-X/Linux/Cygwin. Very good work. Thank you very much. I'll test/fix on MSVC. |
According to https://cmake.org/cmake/help/v3.4/module/FindIntl.html
the FindIntl module already checks for libintl.so.