fix: websocket typeof lint warning #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feri42
reviewed
Feb 25, 2025
| module.exports = globalThis.WebSocket | ||
| } else { | ||
| // Node.js or Electron browser process | ||
| // eslint-disable-next-line unicorn/no-typeof-undefined |
There was a problem hiding this comment.
Is there a good reason for typeof? Why not just globalThis.WebSocket === undefined?
There was a problem hiding this comment.
I think the reason is If WebSocket is not defined (like in older browsers versions, server-side runtimes etc), directly accessing globalThis.WebSocket might throw a ReferenceError if WebSocket is not even declared.
Using typeof ensures the check does not break, as typeof safely returns 'undefined' instead of throwing an error.
feri42
approved these changes
Feb 25, 2025
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lint