-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show verification modal instead of redirecting to concierge #4246
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@thienlnam can you take a look at this? |
@thienlnam Could you review this today pls since it's a daily and it's blocking n6? Do you want me to add someone else for the review? |
Oh I just saw @kevinksullivan's comment, sorry for being too intense hahaha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry just hopped on today - code looks good, going to test before merge
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.82-8🚀
|
@pecanoro @thienlnam Hello! Not sure if we're able to test this on our side. Our testing domains already have the Expensify card so the option to "Finish setup" is not available for us |
We could de-provision the Expensify Card from testing domains you use @isagoico. Then you would be able to add it again. What do you think? |
mmm I think that could work, Can you do it for the Applause.expensifail domain? We don't use that domain for expensify card tests. |
Can do! What specific Applause.expensifail account should I de-provision @isagoico ? Thanks! |
We also tested this on staging and it worked like charm. Thanks for the quick turnaround @pecanoro ! |
So I think we can check this one off @isagoico |
Ok great, thanks @kevinksullivan - Yes lets tick this off! |
🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀
|
Details
Instead of redirecting directly to concierge after adding the 3 validation amounts, if the domain is not auto-provisioned, let's show a new validation modal.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/171381
Tests
QA Steps
Internal -Same steps as above
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android