Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show verification modal instead of redirecting to concierge #4246

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

pecanoro
Copy link
Contributor

@pecanoro pecanoro commented Jul 27, 2021

Details

Instead of redirecting directly to concierge after adding the 3 validation amounts, if the domain is not auto-provisioned, let's show a new validation modal.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/171381

Tests

  1. Create a new account on a private domain + validate it
  2. Create a new chat with a random user and make sure you are navigated to that chat
  3. Create a workspace on this account via Expensify.cash green floating button (create menu)
  4. Navigate to the workspace page and tap Get Started
  5. Verify the Add Bank Account modal appears and follow the instructions here to create a PENDING bank account.
  6. Keep submitting information until you get to the Validate step.
  7. Enter the three amounts to validate the account!
  8. Verify that you now see a new modal + copy with a link to your chat with Concierge.

Expensify cash 2021-07-30 18-43-20

  1. Tap this link and verify you are brought to your chat with Concierge
  2. Navigate back to your workspace page and verify you now see Finish Setup for the button.

Expensify cash 2021-07-30 18-46-19

  1. Tap this button and verify you are brought back to the Validate step.

Expensify cash 2021-07-30 18-43-20

QA Steps

Internal -Same steps as above

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Expensify cash 2021-07-30 18-43-20

Mobile Web

125368141-51bb9b80-e315-11eb-9040-ae6a2d58ab72

Desktop

Expensify cash 2021-07-30 19-01-00

iOS

125369998-2fc41800-e319-11eb-8274-bf317c59f863

Android

125372260-5df82680-e31e-11eb-95b2-348ceb394622

@pecanoro pecanoro self-assigned this Jul 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pecanoro
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@pecanoro pecanoro marked this pull request as ready for review July 30, 2021 22:11
@pecanoro pecanoro requested a review from a team as a code owner July 30, 2021 22:11
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team July 30, 2021 22:11
@kevinksullivan
Copy link
Contributor

@thienlnam can you take a look at this?

@pecanoro
Copy link
Contributor Author

pecanoro commented Aug 2, 2021

@thienlnam Could you review this today pls since it's a daily and it's blocking n6? Do you want me to add someone else for the review?

@pecanoro
Copy link
Contributor Author

pecanoro commented Aug 2, 2021

Oh I just saw @kevinksullivan's comment, sorry for being too intense hahaha

Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just hopped on today - code looks good, going to test before merge

@thienlnam thienlnam merged commit 95f5dba into main Aug 2, 2021
@thienlnam thienlnam deleted the rocio-VBAVerification branch August 2, 2021 16:49
@OSBotify
Copy link
Contributor

OSBotify commented Aug 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

isagoico commented Aug 6, 2021

@pecanoro @thienlnam Hello! Not sure if we're able to test this on our side. Our testing domains already have the Expensify card so the option to "Finish setup" is not available for us
image

@MitchExpensify
Copy link
Contributor

We could de-provision the Expensify Card from testing domains you use @isagoico. Then you would be able to add it again. What do you think?

@isagoico
Copy link

isagoico commented Aug 9, 2021

mmm I think that could work, Can you do it for the Applause.expensifail domain? We don't use that domain for expensify card tests.

@MitchExpensify
Copy link
Contributor

Can do! What specific Applause.expensifail account should I de-provision @isagoico ? Thanks!

@kevinksullivan
Copy link
Contributor

kevinksullivan commented Aug 10, 2021

We also tested this on staging and it worked like charm. Thanks for the quick turnaround @pecanoro !

image

@kevinksullivan
Copy link
Contributor

So I think we can check this one off @isagoico

@MitchExpensify
Copy link
Contributor

Ok great, thanks @kevinksullivan - Yes lets tick this off!

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants