[Search] Add From & To advanced filters #46962

Kicu · 2024-08-07T12:19:28Z

Details

Implements From and To filters, which should behave similarly to existing participants/users selector (similar to for example MoneyRequestParticipantsSelector)
we are saving accountIDs for both filters and sending them as part of AST query
in future we might want to slightly differ options inside From and To filters, but for now they behave the same, which was agreed upon with @luacmartins

Two caveats:

the api is not working correctly yet, which means we get constant loading screen when these filters are set - please don't treat it as bug, backend will fix
on the SearchResults page we display the query to the user and for now we will show just ids: from:<id>,<id2> to:<id>. This looks bad but is a more general issue, and I suggest this is solved in a separate PR where we agree what we want to show to the user. Related discussion about other filters here: Add keyword advanced filter for Search #46799 (comment)

Fixed Issues

$ #46035
PROPOSAL:

Tests

go to /search/filters
click on From filter and test selecting some users
click on To filter and test selecting some users
see that after clicking View Results the correct query is set in browser URL and correct Network request payload is sent; API might not return correct data yet

Offline tests

QA Steps

go to /search/filters
click on From filter and test selecting some users
click on To filter and test selecting some users
see that after clicking View Results data is correctly filtered

PR Author Checklist

Screenshots/Videos

Android: Native

rec-andr-participant-filter.mp4

Android: mWeb Chrome

rec-webandr-filters.mp4

iOS: Native

rec-ios-participant-filter.mp4

iOS: mWeb Safari

rec-webios-filters.mp4

MacOS: Chrome / Safari

rec-web-participant-filter.mp4

MacOS: Desktop

Kicu · 2024-08-07T12:26:57Z

@luacmartins Please take a look at the code of SearchFiltersParticipantsSelector. I have mostly based this on MoneyRequestParticipantsSelector but the code there is quite complex so I only copied pieces of it.
The flow is moreless:

get personalDetails from usePersonalDetails
get options from useOptionsList
transform the data options -> OptionsListUtils.getFilteredOptions -> OptionsListUtils.filterOptions -> OptionsListUtils.formatSectionsFromSearchTerm
I kinda implemented this via trial&error.

If you search for InviteMemberListItem you will see that there are 6 other places where such a list is displayed and each sections generation is slightly different:

☝️ not sure which one is the closest to ours.

Questions:

does my code make sense? are all the formatting functions needed?
my code right now will NOT do any api search calls like money request selector - should I add it?
Is saving accountID correct? and is the displaying of chosen values also correct? (If yes then I will modify the thing that displays query to the user so that it also displays the names instead of ids

luacmartins

I think what you have here is a great start. I think the from options could be simplified to only users, so no reports, etc. That being said, we can start with the same logic for both filters to get this one out and then adjust later.

The to option should be the same as we have in MoneyRequestParticipantsSelector, which is what you implemented here. The only thing that we could leave out is the Recents and Contacts section, but I think that'd be more work so let's go with what you have here. I left a suggestion for the options though, so we exclude/include a few more options.

Everything else looks good. One thing that I noticed is that the backend filter will not work with reportIDs right now, so I'll need to update it to handle those as well.

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersParticipantsSelector.tsx

luacmartins · 2024-08-07T17:07:39Z

does my code make sense? are all the formatting functions needed?

Answered above, but yes these options should mirror what we have in MoneyRequestParticipantsSelector

my code right now will NOT do any api search calls like money request selector - should I add it?

I think we can keep the same logic we have in MoneyRequestParticipantsSelector, so:

...

const [isSearchingForReports] = useOnyx(ONYXKEYS.IS_SEARCHING_FOR_REPORTS, {initWithStoredValues: false});

...

 useEffect(() => {
        Report.searchInServer(debouncedSearchTerm.trim());
    }, [debouncedSearchTerm]);

...

isLoadingNewOptions={!!isSearchingForReports}

Is saving accountID correct? and is the displaying of chosen values also correct? (If yes then I will modify the thing that displays query to the user so that it also displays the names instead of ids

Yea, this looked correct to me when I tested this PR.

melvin-bot · 2024-08-08T12:43:24Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-djouah · 2024-08-09T06:02:30Z

@Kicu - We have merge conflicts, Could you please merge main?

src/libs/SearchUtils.ts

src/types/form/SearchAdvancedFiltersForm.ts

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersParticipantsSelector.tsx

rayane-djouah · 2024-08-09T06:31:31Z

Bug 1: We're handling persons in "From" and "To" filters but we're not correctly handling workspaces:

Screen.Recording.2024-08-09.at.7.29.02.AM.mov

rayane-djouah · 2024-08-09T06:43:00Z

Hmm, If we set a "To" account id filter, backend is returning expenses submitted to the user or to a policy in which the user is manager of the report. is this expected @luacmartins?

Screen.Recording.2024-08-09.at.7.34.17.AM.mov

rayane-djouah · 2024-08-09T06:55:13Z

Bug 2: If I search for my account in "From" or "To" filters participant selector I only get my workspaces and can't select my account as a value:

Kicu · 2024-08-09T07:48:31Z

conflicts with main are solved, I will be looking at review comments soon

luacmartins · 2024-08-09T09:05:52Z

Bug 1: We're handling persons in "From" and "To" filters but we're not correctly handling workspaces:

This bug is also partly on the backend, so I'll need to fix that in the API too.

luacmartins · 2024-08-09T09:06:58Z

Hmm, If we set a "To" account id filter, backend is returning expenses submitted to the user or to a policy in which the user is manager of the report. is this expected @luacmartins?

Yea, I think this is expected for now. I'm not sure if we have a way to tell them apart since the ultimate person that expense was submitted to is also the selected user.

Kicu · 2024-08-09T09:10:20Z

@luacmartins for Bug 1 what id should be sent for workspace selection? should the list of ids saved in filter be a mix of accountID for people and policyID/reportID for workspaces?
Btw we also have a dedicated reportID filter (at least according to design doc) so how will these two coexist?

luacmartins · 2024-08-09T09:16:50Z

Great questions! I'm trying to figure that out too haha

@trjExpensify @JmillsExpensify what is the expected behavior when users select a workspace on the from/to filter? Do we lookup the admin accountIDs for that workspace and include all admins when searching?

Kicu · 2024-08-09T10:57:13Z

I implemented most of the stuff, but still waiting on decision for Bug 1 whether to allow reports and what id to save.

As for Bug 1 it is solved but in a tricky way.
I looked at what function calls are made in NewChat page, because in there you can pick yourself. I noticed in there we set maxRecentReportsToShow: 0, which actually allows for all recentReports. The option representing own user is within these recentReports. So I did the same for Filters and now it seems to work.
In many other Pickers you can't select yourself, so I don't know whether there is a better solution to this problem or not.

luacmartins · 2024-08-09T13:28:33Z

I looked at what function calls are made in NewChat page, because in there you can pick yourself. I noticed in there we set maxRecentReportsToShow: 0, which actually allows for all recentReports. The option representing own user is within these recentReports. So I did the same for Filters and now it seems to work.

That seems like a workaround haha I spent some time trying to figure out where we filter the current user out, but got lost in the complex logic. Ideally we find out where we're filtering the current user out and add an option to not do so.

luacmartins · 2024-08-09T14:15:38Z

@Kicu so interesting development. The from and to filters should include only individuals, no reports or workspace chats. As part of a separate issue, we'll also be updating the table to show To as the manager of the report, instead of the policy, like we do today (see image below):

rayane-djouah · 2024-08-13T10:52:32Z

Will re-review shortly

ios/tmp.xcconfig

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersFromPage.tsx

rayane-djouah · 2024-08-13T11:43:24Z

src/components/Search/SearchFiltersParticipantsSelector.tsx

+            }}
+            onSelectRow={handleParticipantSelection}
+            isLoadingNewOptions={!!isSearchingForReports}
+        />


We are not displaying "No results" header message when there are no results, we need to add a logic for noResultsFound like we're doing in SearchMultipleSelectionPicker for example

Suggested change

/>

headerMessage={noResultsFound ? translate('common.noResultsFound') : undefined}

/>

rayane-djouah · 2024-08-13T11:49:48Z

src/components/Search/SearchFiltersParticipantsSelector.tsx

+        newSections.push({
+            title: '',
+            data: chatOptions.recentReports,
+            shouldShow: chatOptions.recentReports.length > 0,
+        });
+
+        newSections.push({
+            title: '',
+            data: chatOptions.personalDetails,
+            shouldShow: chatOptions.personalDetails.length > 0,
+        });


There is a delay between displaying the personalDetails options and the recentReports options. However, I’m wondering if we even need to include the recentReports options at all. Shouldn’t we display the personalDetails options along with the currentUserOption only?

Screen.Recording.2024-08-13.at.12.36.40.PM.mov

It totally made sense to me, but it turns out that a lot of the search options is actually coming from recentReports :/ I don't fully understand how this whole feature of searching works.
I tried removing recent searches in this commit: 68969fe

and the result is that you cannot find almost any option. It seems that most (if not all) results of searching for users is actually stored inside chatOptions.recentReports and not chatOptions.personalDetails.

I will bring recent reports back in a separate comment. Feel free to test this yourself by removing/adding the recentReports section.
How this works is quite confusing 😕

This is wild 🤯 I'm also not sure why that'd be the case, but it seems like we need to keep recentReports for now.

src/components/Search/SearchFiltersParticipantsSelector.tsx

Kicu · 2024-08-13T14:30:55Z

fixed wrong name, fixed "no results" header message missing, and removed recent reports.

@rayane-djouah
About the slow loading, I don't know what else we can do. I have removed recents (which I think is a good idea).
Still we get part of results loaded immediately and then part of them gets delayed. However you can see in my video that this is not because of logic of passing options to list, but rather I think because of the List rendering itself.

In the video below I'm logging length of options passed to the component. This is logged in rendering SearchParticipantsSelector. You can see that at first we pass 0 options, then we pass all the options. There is no inbetween value, but the loading gets delayed anyways.
Feels like a problem inside SelectionList maybe 🤔

rec-web-userlist.mp4

rayane-djouah · 2024-08-13T14:56:24Z

src/components/Search/SearchFiltersParticipantsSelector.tsx

+                setSearchTerm(value);
+            }}
+            onSelectRow={handleParticipantSelection}
+            isLoadingNewOptions={!!isSearchingForReports}


I think that displaying this screen with a loading screen until we have all the data and pre-select options is a good idea. we are doing this in other selection lists like MoneyRequestParticipantsSelector

Suggested change

isLoadingNewOptions={!!isSearchingForReports}

isLoadingNewOptions={!!isSearchingForReports}

showLoadingPlaceholder={!didScreenTransitionEnd || !areOptionsInitialized || !initialAccountIDs || !personalDetails}

I agree. We can show the loading skeleton until the list is fully loaded, like we do for the start chat list

Screen.Recording.2024-08-13.at.10.25.19.AM.mov

src/components/Search/SearchFiltersParticipantsSelector.tsx

rayane-djouah · 2024-08-13T15:14:47Z

src/components/Search/SearchFiltersParticipantsSelector.tsx

+    const noResultsFound = chatOptions.personalDetails.length === 0 && chatOptions.recentReports.length === 0 && !chatOptions.currentUserOption;
+    const headerMessage = noResultsFound ? translate('common.noResultsFound') : undefined;


Suggested change

const noResultsFound = chatOptions.personalDetails.length === 0 && chatOptions.recentReports.length === 0 && !chatOptions.currentUserOption;

const headerMessage = noResultsFound ? translate('common.noResultsFound') : undefined;

src/components/Search/SearchFiltersParticipantsSelector.tsx

luacmartins · 2024-08-13T16:32:52Z

Nice, seems like we're really close to getting this merged!

luacmartins

Looking good. Left a small suggestion

src/components/Search/SearchFiltersParticipantsSelector.tsx

Kicu · 2024-08-14T13:56:17Z

Please re-review @rayane-djouah @luacmartins
Im busy today with something, but wanted to finalise this PR (but also rushed this a bit). Also I'm OOO and back on Monday, so would be best to merge this today if possible 🙏

I hope I implemented all the suggestions.
List loading feels smooth right now.

rec-web-filters-loading.mp4

rayane-djouah

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-14.at.3.06.16.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-08-14.at.3.02.18.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-14.at.15.09.46.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-14.at.14.56.38.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-08-14.at.2.49.25.PM.mov

MacOS: Desktop

Screen.Recording.2024-08-14.at.3.01.17.PM.mov

rayane-djouah · 2024-08-14T14:16:36Z

I've found a bug reproducible on all the filters pages: the Save button is hidden behind the keyboard on mWeb Safari (you need to dismiss the keyboard to click on the save button):

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-14.at.14.59.08.mp4

Do you prefer to address this separately?

luacmartins · 2024-08-14T14:17:58Z

I've found a bug reproducible on all the filters pages: the Save button is hidden behind the keyboard on mWeb Safari (you need to dismiss the keyboard to click on the save button):

Yea, let's fix that in a follow up. cc @SzymczakJ @Guccio163 since you're working on the next filters.

luacmartins

LGTM!

OSBotify · 2024-08-14T14:37:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-15T18:18:42Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

techievivek · 2024-08-16T06:15:30Z

Hi @luacmartins @Kicu, We have a tiny problem here that we can work on as a follow-up: #47537. I will assign the GH to you guys. Thanks.

luacmartins · 2024-08-16T13:29:34Z

Thanks for the ping! We'll work on a fix.

OSBotify · 2024-08-19T15:59:46Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

OSBotify · 2024-08-19T16:24:09Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Kicu added 2 commits August 6, 2024 17:31

Add initial version of from filter with member list

7a627f6

Add from and to filters and display their value in advanced filters

c13df36

luacmartins requested changes Aug 7, 2024

View reviewed changes

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersParticipantsSelector.tsx Outdated Show resolved Hide resolved

Kicu added 2 commits August 8, 2024 10:22

Merge branch 'main' into kicu/46035-from-to-filters

4aeedd0

Add api searching to From/To advanced filters in Search

8f5be97

Kicu force-pushed the kicu/46035-from-to-filters branch from 2143b5b to 8f5be97 Compare August 8, 2024 08:59

Kicu marked this pull request as ready for review August 8, 2024 12:43

Kicu requested a review from a team as a code owner August 8, 2024 12:43

melvin-bot bot requested review from rayane-djouah and removed request for a team August 8, 2024 12:43

luacmartins self-requested a review August 8, 2024 13:33

SzymczakJ mentioned this pull request Aug 8, 2024

Search filters: tax, expense type and tag #46736

Merged

49 tasks

rayane-djouah suggested changes Aug 9, 2024

View reviewed changes

src/libs/SearchUtils.ts Outdated Show resolved Hide resolved

src/types/form/SearchAdvancedFiltersForm.ts Outdated Show resolved Hide resolved

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersParticipantsSelector.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into kicu/46035-from-to-filters

ad96ccc

Increase amount of report options displayed in Search filters

7abf07d

rayane-djouah reviewed Aug 13, 2024

View reviewed changes

ios/tmp.xcconfig Outdated Show resolved Hide resolved

Remove temp file

e0d407d

Guccio163 reviewed Aug 13, 2024

View reviewed changes

src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersFromPage.tsx Outdated Show resolved Hide resolved

rayane-djouah reviewed Aug 13, 2024

View reviewed changes

src/components/Search/SearchFiltersParticipantsSelector.tsx Show resolved Hide resolved

Remove recent reports section in From/To filters and fix header

68969fe

Bring back recentReports in advanced filters to fix searching for users

a4d2221

rayane-djouah reviewed Aug 13, 2024

View reviewed changes

luacmartins requested changes Aug 13, 2024

View reviewed changes

src/components/Search/SearchFiltersParticipantsSelector.tsx Outdated Show resolved Hide resolved

Display correct message and loading placeholder in advanced filter

278ba21

rayane-djouah approved these changes Aug 14, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins August 14, 2024 14:12

luacmartins approved these changes Aug 14, 2024

View reviewed changes

luacmartins merged commit 04d0b1b into Expensify:main Aug 14, 2024
16 checks passed

github-actions bot mentioned this pull request Aug 15, 2024

Deploy Checklist: New Expensify 2024-08-15 #47512

Closed

74 tasks

IuliiaHerets mentioned this pull request Aug 16, 2024

Search - Own email address is displayed twice on /search/filters page #47537

Closed

6 tasks

	/>
	headerMessage={noResultsFound ? translate('common.noResultsFound') : undefined}
	/>

	isLoadingNewOptions={!!isSearchingForReports}
	isLoadingNewOptions={!!isSearchingForReports}
	showLoadingPlaceholder={!didScreenTransitionEnd \|\| !areOptionsInitialized \|\| !initialAccountIDs \|\| !personalDetails}

		const noResultsFound = chatOptions.personalDetails.length === 0 && chatOptions.recentReports.length === 0 && !chatOptions.currentUserOption;
		const headerMessage = noResultsFound ? translate('common.noResultsFound') : undefined;

[Search] Add From & To advanced filters #46962

[Search] Add From & To advanced filters #46962

Conversation

Kicu commented Aug 7, 2024 • edited Loading

Details

Two caveats:

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Kicu commented Aug 7, 2024 • edited Loading

Questions:

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Aug 7, 2024

melvin-bot bot commented Aug 8, 2024

rayane-djouah commented Aug 9, 2024

rayane-djouah commented Aug 9, 2024 • edited Loading

rayane-djouah commented Aug 9, 2024 • edited Loading

rayane-djouah commented Aug 9, 2024 • edited Loading

Kicu commented Aug 9, 2024

luacmartins commented Aug 9, 2024

luacmartins commented Aug 9, 2024

Kicu commented Aug 9, 2024

luacmartins commented Aug 9, 2024

Kicu commented Aug 9, 2024 • edited Loading

luacmartins commented Aug 9, 2024

luacmartins commented Aug 9, 2024

rayane-djouah commented Aug 13, 2024 • edited Loading

rayane-djouah Aug 13, 2024 • edited Loading

Choose a reason for hiding this comment

rayane-djouah Aug 13, 2024 • edited Loading

Choose a reason for hiding this comment

Kicu Aug 13, 2024

Choose a reason for hiding this comment

luacmartins Aug 13, 2024

Choose a reason for hiding this comment

Kicu commented Aug 13, 2024

rayane-djouah Aug 13, 2024

Choose a reason for hiding this comment

luacmartins Aug 13, 2024

Choose a reason for hiding this comment

rayane-djouah Aug 13, 2024

Choose a reason for hiding this comment

luacmartins commented Aug 13, 2024

luacmartins left a comment

Choose a reason for hiding this comment

Kicu commented Aug 14, 2024 • edited Loading

rayane-djouah left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

rayane-djouah commented Aug 14, 2024

luacmartins commented Aug 14, 2024 • edited Loading

luacmartins left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 14, 2024

OSBotify commented Aug 15, 2024

techievivek commented Aug 16, 2024

luacmartins commented Aug 16, 2024

OSBotify commented Aug 19, 2024

OSBotify commented Aug 19, 2024

Kicu commented Aug 7, 2024 •

edited

Loading

Kicu commented Aug 7, 2024 •

edited

Loading

rayane-djouah commented Aug 9, 2024 •

edited

Loading

rayane-djouah commented Aug 9, 2024 •

edited

Loading

rayane-djouah commented Aug 9, 2024 •

edited

Loading

Kicu commented Aug 9, 2024 •

edited

Loading

rayane-djouah commented Aug 13, 2024 •

edited

Loading

rayane-djouah Aug 13, 2024 •

edited

Loading

rayane-djouah Aug 13, 2024 •

edited

Loading

Kicu commented Aug 14, 2024 •

edited

Loading

luacmartins commented Aug 14, 2024 •

edited

Loading