Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflow to auto-publish to NPM #210

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

luacmartins
Copy link
Contributor

This PR implements a GitHub workflow that automatically publishes a new version of the library to NPM every time a PR is merged to main.

Tests

  1. Merge this PR
  2. Verify that it triggers the publish workflow
  3. Verify that a new release is created and published to NPM

@luacmartins
Copy link
Contributor Author

Updated!

justinpersaud
justinpersaud previously approved these changes Aug 27, 2024
Co-authored-by: Justin Persaud <justinpersaud@gmail.com>
@luacmartins
Copy link
Contributor Author

Updated node version!

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor thing but it's too :eye_twitch: to be NAB

luacmartins and others added 2 commits August 27, 2024 14:28
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
@luacmartins
Copy link
Contributor Author

Updated

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to wait for the permissions update before merging

@justinpersaud
Copy link
Contributor

Permissions were already updated

@roryabraham
Copy link
Contributor

roryabraham commented Aug 27, 2024

Nice, let's give this a go then

@roryabraham roryabraham merged commit 3c28bb5 into main Aug 27, 2024
@luacmartins
Copy link
Contributor Author

Hmm maybe we missed some permission @justinpersaud? I'm seeing:

Run git push origin main && git push --tags
remote: error: GH013: Repository rule violations found for refs/heads/main.        
remote: Review all repository rules at http://github.com/Expensify/react-native-qrcode-svg/rules?ref=refs%2Fheads%2Fmain        
remote: 
remote: - Changes must be made through a pull request.        
remote: 
To https://github.com/Expensify/react-native-qrcode-svg
 ! [remote rejected] main -> main (push declined due to repository rule violations)
error: failed to push some refs to 'https://github.com/Expensify/react-native-qrcode-svg'
Error: Process completed with exit code 1.

@roryabraham
Copy link
Contributor

Might also check that the OS_BOTIFY_COMMIT_TOKEN is accessible in this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants