-
Notifications
You must be signed in to change notification settings - Fork 129
Enabled synchronizing upload directory via CLI; #3044 #3615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@intoeetive is there any reason we wouldn't want to allow this to be called without specifying a specific upload location? I'm thinking if someone needed to call this on a cron job it might be helpful to not require calling each upload location as a separate command. Also as locations are added/removed any scripting would need to update too. Just a thought, we don't necessarily need to tackle that now. |
@bryannielsen we're making it work same way as it works in the CP. It might make sense toy have it also worrk globally (loop through all upload locations) but I'd say that can be separate FR |
@matthewjohns0n I think the error is actually because you have {base_path} used in server path, and it's set to DOCUMENT_ROOT or similar, so you get wrong path. Since this is common case, I added error check. Also the other issue are resolved now. Please test again |
@bakin1999 you're absolutely right. I was so happy about my fix that made it way more strict than it should be :) All should be good now |
great is working again! |
Enabled synchronizing upload directory via CLI; #3044
User Guide: ExpressionEngine/ExpressionEngine-User-Guide#702