Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send match_ready to server immediatley on match_found (#1783) #2324

Closed
wants to merge 3 commits into from

Conversation

Katharsas
Copy link
Collaborator

Since i do not have a full local environment i can only start testing this when FAForever/server#820 is released on test or prod.

Waiting for clarification on FAForever/server#607 (comment)

@Sheikah45
Copy link
Member

the ready party message is already implemented. You should just use that.

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #2324 (e7a40dc) into develop (bba6b50) will decrease coverage by 0.02%.
The diff coverage is 16.66%.

❗ Current head e7a40dc differs from pull request most recent head 774cf79. Consider uploading reports for the commit 774cf79 to get more accurate results

@@              Coverage Diff              @@
##             develop    #2324      +/-   ##
=============================================
- Coverage      59.18%   59.16%   -0.03%     
  Complexity      4035     4035              
=============================================
  Files            518      520       +2     
  Lines          19389    19395       +6     
  Branches        1179     1179              
=============================================
- Hits           11476    11475       -1     
- Misses          7293     7300       +7     
  Partials         620      620              
Impacted Files Coverage Δ
...faforever/client/remote/FafServerAccessorImpl.java 72.50% <0.00%> (-0.31%) ⬇️
...n/java/com/faforever/client/remote/FafService.java 12.66% <0.00%> (-0.05%) ⬇️
...faforever/client/remote/MockFafServerAccessor.java 0.00% <0.00%> (ø)
...nt/remote/domain/inbound/faf/MatchInfoMessage.java 0.00% <0.00%> (ø)
.../remote/domain/outbound/faf/MatchReadyMessage.java 0.00% <0.00%> (ø)
...client/teammatchmaking/TeamMatchmakingService.java 85.77% <100.00%> (+0.06%) ⬆️
...main/java/com/faforever/client/map/MapService.java 63.56% <0.00%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba6b50...774cf79. Read the comment docs.

@Sheikah45
Copy link
Member

The new message needs to be implemented in the lobby client

@Sheikah45
Copy link
Member

This is out of date now

@Sheikah45 Sheikah45 closed this Nov 6, 2021
@Sheikah45 Sheikah45 deleted the feature/#1783-match-confirmation-dummy branch November 13, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants