-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ZGC for garbage collection #2951
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2951 +/- ##
=============================================
- Coverage 61.34% 61.33% -0.01%
Complexity 4595 4595
=============================================
Files 557 557
Lines 20186 20186
Branches 1048 1048
=============================================
- Hits 12383 12381 -2
- Misses 7217 7219 +2
Partials 586 586 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Halved? That's huge! |
Yeah, that is amazing - have found no bugs so far, still testing it. |
Yeah I ran through some tests with it. Still not entirely sure why. A lot of the memory used by the client is actually off heap, so it is rather hard to track down. So I was a little surprised when using the ZGC collector reported so much less memory usage. I am still investigating some as to why hence why this is not merged but figured I would send it out to be tested so others could confirm if it happened for them as well. |
And previously this "unknown" memory segment was partly due to the Webviews. But using the ZGC the os reported memory actually correlates with the heap+nonheap memory. Where as before ~500MB were due to either the GC or some other native memory purpose. But I do not know why anything other than the memory of the GC would change just from the GC change. |
@@ -167,15 +167,11 @@ bootRun { | |||
jvmArgs = [ | |||
"-DnativeDir=build/resources/native", | |||
"-Dprism.forceGPU=true", | |||
"-Xms128m", | |||
"-Xmx712m", | |||
"-Xmx1g", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With how ZGC operates it needs a little bit more heap overhead in order to operate properly without constantly performing concurrent GCs and kicking up CPU usage
faf-client.install4j
Outdated
# Adjust maximum memory usage to 712MiB | ||
-Xmx712m | ||
-XX:ConcGCThreads=1 | ||
-XX:ParallelGCThreads=1 | ||
-XX:+UseG1GC | ||
-Xmx1g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment would also need to be adjusted (or just removed).
b776434
to
3cb3eca
Compare
On my system noticed the OS reported memory usage was halved