Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace isPresent where possible #2980

Merged
merged 1 commit into from
May 27, 2023
Merged

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #2980 (0bf482a) into develop (984fae6) will increase coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head 0bf482a differs from pull request most recent head 0b9d0f7. Consider uploading reports for the commit 0b9d0f7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2980   +/-   ##
==========================================
  Coverage      62.07%   62.08%           
+ Complexity      4699     4696    -3     
==========================================
  Files            558      558           
  Lines          20286    20275   -11     
  Branches        1058     1053    -5     
==========================================
- Hits           12593    12588    -5     
+ Misses          7089     7087    -2     
+ Partials         604      600    -4     
Impacted Files Coverage Δ
...a/com/faforever/client/chat/KittehChatService.java 72.86% <42.85%> (+0.28%) ⬆️
...aforever/client/chat/PrivateChatTabController.java 75.00% <75.00%> (+0.80%) ⬆️
.../com/faforever/client/ui/tray/TrayIconManager.java 85.71% <75.00%> (+1.71%) ⬆️
...main/java/com/faforever/client/mod/ModService.java 77.00% <80.00%> (+0.61%) ⬆️
...forever/client/chat/AbstractChatTabController.java 74.32% <100.00%> (-0.09%) ⬇️
...om/faforever/client/chat/ChannelTabController.java 88.95% <100.00%> (+0.48%) ⬆️
...main/java/com/faforever/client/map/MapService.java 70.44% <100.00%> (ø)
...ent/ui/tray/event/UpdateApplicationBadgeEvent.java 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984fae6...0b9d0f7. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 8f8e2eb into develop May 27, 2023
@Sheikah45 Sheikah45 deleted the maintenance/replace-is-present branch May 27, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant