Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework javafxutil static calls #2982

Merged
merged 3 commits into from
May 28, 2023
Merged

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #2982 (042a408) into develop (8f8e2eb) will decrease coverage by 0.72%.
The diff coverage is 77.91%.

❗ Current head 042a408 differs from pull request most recent head 8c917ad. Consider uploading reports for the commit 8c917ad to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2982      +/-   ##
=============================================
- Coverage      62.09%   61.38%   -0.72%     
+ Complexity      4695     4598      -97     
=============================================
  Files            558      558              
  Lines          20275    20205      -70     
  Branches        1053     1049       -4     
=============================================
- Hits           12590    12402     -188     
- Misses          7086     7218     +132     
+ Partials         599      585      -14     
Impacted Files Coverage Δ
...ava/com/faforever/client/FafClientApplication.java 3.07% <ø> (+0.04%) ⬆️
...main/java/com/faforever/client/StartupService.java 0.00% <0.00%> (ø)
...com/faforever/client/config/PreferencesConfig.java 0.00% <0.00%> (ø)
.../java/com/faforever/client/fx/BrowserCallback.java 14.28% <0.00%> (ø)
...va/com/faforever/client/fx/DualStringListCell.java 0.00% <0.00%> (ø)
...va/com/faforever/client/fx/IconButtonListCell.java 0.00% <0.00%> (ø)
.../java/com/faforever/client/fx/PlatformService.java 1.44% <0.00%> (ø)
...java/com/faforever/client/game/JoinGameHelper.java 66.66% <0.00%> (ø)
...com/faforever/client/mod/ModManagerController.java 58.46% <0.00%> (-0.92%) ⬇️
...java/com/faforever/client/news/NewsController.java 0.00% <0.00%> (ø)
... and 76 more

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8e2eb...8c917ad. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 550b34f into develop May 28, 2023
@Sheikah45 Sheikah45 deleted the maintenance/javafxutil-overhaul branch May 28, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant