Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition with review supplier for replays #2990

Merged
merged 1 commit into from
Jun 11, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #2990 (191f93b) into develop (5f65e3a) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 191f93b differs from pull request most recent head 7facdbf. Consider uploading reports for the commit 7facdbf to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2990      +/-   ##
=============================================
- Coverage      61.33%   61.28%   -0.06%     
+ Complexity      4594     4590       -4     
=============================================
  Files            557      557              
  Lines          20185    20186       +1     
  Branches        1048     1048              
=============================================
- Hits           12381    12371      -10     
- Misses          7218     7228      +10     
- Partials         586      587       +1     
Impacted Files Coverage Δ
...forever/client/vault/review/ReviewsController.java 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f65e3a...7facdbf. Read the comment docs.

@Sheikah45 Sheikah45 merged commit b539935 into develop Jun 11, 2023
@Sheikah45 Sheikah45 deleted the bugfix/replay-review branch June 11, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant