Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reactor for UserService #2996

Merged
merged 5 commits into from
Jun 17, 2023
Merged

Use reactor for UserService #2996

merged 5 commits into from
Jun 17, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@Sheikah45 Sheikah45 force-pushed the maintenance/login-mono branch from d2a79e8 to 5f5d4fa Compare June 17, 2023 01:31
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #2996 (91a4c97) into develop (ef8b32a) will decrease coverage by 0.07%.
The diff coverage is 57.14%.

❗ Current head 91a4c97 differs from pull request most recent head 74bd79a. Consider uploading reports for the commit 74bd79a to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2996      +/-   ##
=============================================
- Coverage      61.43%   61.36%   -0.07%     
+ Complexity      4590     4586       -4     
=============================================
  Files            556      556              
  Lines          20142    20119      -23     
  Branches        1046     1043       -3     
=============================================
- Hits           12375    12347      -28     
- Misses          7181     7192      +11     
+ Partials         586      580       -6     
Impacted Files Coverage Δ
...a/com/faforever/client/chat/KittehChatService.java 63.03% <0.00%> (-9.84%) ⬇️
...com/faforever/client/remote/FafServerAccessor.java 80.15% <25.00%> (+5.34%) ⬆️
...in/java/com/faforever/client/user/UserService.java 75.43% <60.00%> (-5.99%) ⬇️
.../java/com/faforever/client/api/FafApiAccessor.java 92.94% <100.00%> (ø)
...va/com/faforever/client/login/LoginController.java 87.64% <100.00%> (ø)
...om/faforever/client/main/UserButtonController.java 81.81% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef8b32a...74bd79a. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 3392be5 into develop Jun 17, 2023
@Sheikah45 Sheikah45 deleted the maintenance/login-mono branch June 17, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant