Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event bus usage for login events #2997

Merged
merged 3 commits into from
Jun 18, 2023
Merged

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #2997 (3b3955c) into develop (3392be5) will increase coverage by 0.06%.
The diff coverage is 69.62%.

❗ Current head 3b3955c differs from pull request most recent head 384cbd3. Consider uploading reports for the commit 384cbd3 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2997      +/-   ##
=============================================
+ Coverage      61.31%   61.37%   +0.06%     
- Complexity      4582     4583       +1     
=============================================
  Files            556      551       -5     
  Lines          20119    20107      -12     
  Branches        1043     1045       +2     
=============================================
+ Hits           12335    12340       +5     
+ Misses          7204     7183      -21     
- Partials         580      584       +4     
Impacted Files Coverage Δ
...ava/com/faforever/client/FafClientApplication.java 2.94% <0.00%> (-0.19%) ⬇️
...ava/com/faforever/client/api/OAuthTokenFilter.java 0.00% <0.00%> (ø)
.../main/java/com/faforever/client/fx/JavaFxUtil.java 68.71% <ø> (+6.39%) ⬆️
...ava/com/faforever/client/game/GamePathHandler.java 25.00% <0.00%> (-2.09%) ⬇️
...aforever/client/login/NoRefreshTokenException.java 100.00% <ø> (ø)
...forever/client/preferences/PreferencesService.java 11.29% <0.00%> (ø)
.../com/faforever/client/replay/ReplayServerImpl.java 0.00% <0.00%> (ø)
...client/teammatchmaking/TeamMatchmakingService.java 87.02% <16.66%> (ø)
...va/com/faforever/client/game/VaultPathHandler.java 56.66% <20.00%> (-15.21%) ⬇️
...a/com/faforever/client/chat/KittehChatService.java 62.92% <34.61%> (-0.12%) ⬇️
... and 24 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3392be5...384cbd3. Read the comment docs.

@Sheikah45 Sheikah45 merged commit bb3a394 into develop Jun 18, 2023
@Sheikah45 Sheikah45 deleted the maintenance/login-events branch June 18, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant