Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break header into its own component parts #3002

Merged
merged 2 commits into from
Jun 25, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #3002 (dcc64e0) into develop (7ef58fa) will increase coverage by 0.00%.
The diff coverage is 63.77%.

❗ Current head dcc64e0 differs from pull request most recent head f269f14. Consider uploading reports for the commit f269f14 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3002   +/-   ##
==========================================
  Coverage      61.33%   61.34%           
- Complexity      4582     4591    +9     
==========================================
  Files            551      554    +3     
  Lines          20118    20131   +13     
  Branches        1045     1044    -1     
==========================================
+ Hits           12340    12349    +9     
- Misses          7194     7197    +3     
- Partials         584      585    +1     
Impacted Files Coverage Δ
...forever/client/headerbar/UserButtonController.java 81.81% <ø> (ø)
...va/com/faforever/client/login/LoginController.java 87.50% <ø> (-0.15%) ⬇️
.../faforever/client/main/LinksAndHelpController.java 0.00% <ø> (ø)
...ver/client/headerbar/MainMenuButtonController.java 30.00% <30.00%> (ø)
...ent/teammatchmaking/TeamMatchmakingController.java 91.46% <50.00%> (-0.84%) ⬇️
...aforever/client/headerbar/HeaderBarController.java 78.18% <78.18%> (ø)
...client/headerbar/NotificationButtonController.java 84.61% <84.61%> (ø)
...java/com/faforever/client/main/MainController.java 50.00% <100.00%> (-3.36%) ⬇️
...n/java/com/faforever/client/user/LoginService.java 74.60% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1880e...f269f14. Read the comment docs.

@Sheikah45 Sheikah45 force-pushed the maintenance/main-controller-rework branch from 5ef2574 to f269f14 Compare June 25, 2023 16:41
@Sheikah45 Sheikah45 merged commit 60d95b2 into develop Jun 25, 2023
@Sheikah45 Sheikah45 deleted the maintenance/main-controller-rework branch June 25, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant