Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use ZGC on win7 or win8 #3003

Merged
merged 3 commits into from
Jul 1, 2023
Merged

Don't use ZGC on win7 or win8 #3003

merged 3 commits into from
Jul 1, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@Sheikah45 Sheikah45 temporarily deployed to deploy June 29, 2023 23:27 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3003 (5dac977) into develop (a857a0d) will not change coverage.
The diff coverage is n/a.

❗ Current head 5dac977 differs from pull request most recent head dc51d77. Consider uploading reports for the commit dc51d77 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3003   +/-   ##
==========================================
  Coverage      61.35%   61.35%           
- Complexity      4590     4591    +1     
==========================================
  Files            554      554           
  Lines          20132    20132           
  Branches        1044     1044           
==========================================
  Hits           12352    12352           
- Misses          7194     7195    +1     
+ Partials         586      585    -1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a857a0d...dc51d77. Read the comment docs.

@Sheikah45 Sheikah45 temporarily deployed to deploy June 29, 2023 23:40 — with GitHub Actions Inactive
@micheljung
Copy link
Member

Would be good if you explained the motivation behind it in the commit message.

@bukajsytlos
Copy link
Member

will this change affect Linux users?

@Sheikah45 Sheikah45 changed the title Don't use ZGC on win7 Don't use ZGC on win7 or win8 Jun 30, 2023
@Sheikah45
Copy link
Member Author

Zgc is only supported on windows builds greater than win 10 1803 due to older versions lacking a newer windows memory API.

It does not affect Linux users because they don't use install4j and manage their own vmoptions

@Sheikah45 Sheikah45 enabled auto-merge (squash) July 1, 2023 01:41
@Sheikah45 Sheikah45 merged commit cf1c33d into develop Jul 1, 2023
@Sheikah45 Sheikah45 deleted the bugfix/win7-zgc-fix branch July 1, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants